Random.randint not generating a random number in Python

Question

This function (playCraps()) is supposed to choose two random integers between 1 and 6, sum them up, and return a True or False value held in x.
For some reason, each time I run the program, it always returns True with either 7 or 11.

import random

wins = [7, 11]
losses = [2, 3, 12]

def playCraps():
    x = 0 
    while x == 0:
       sumDice = random.randint(1,6) + random.randrange(1,6) 
       if sumDice in wins:
           x = True 
       elif sumDice in losses:
           x = False 
       else:
           sumDice = 0 
print("The sum of the dice was " + str(sumDice)) 
print("So the boolean value is " + str(x))

Why does this happen? And how can this be fixed?

This is not valid python code. Could you please fix the indentation, such that we can track down the error? — David Zwicker
– David Zwicker, Commented Feb 13, 2016 at 20:30

Idos · Accepted Answer · 2016-02-13 20:42:52Z

2

You always get True because your while loop will execute even if x is False. 0 is a falsy value in Python. Example:

>>> x = False
>>> if x == 0:
        print 'x == 0 is falsy'
x == 0 is falsy

So your loop will eventually give True no matter what. A possible solution will be to define:

x = False 
while not x:
    ...

edited Feb 13, 2016 at 20:42

answered Feb 13, 2016 at 20:34

Idos

15.3k14 gold badges63 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Will Sherwood Over a year ago

should be while not x

rlfrick Over a year ago

This was my issue, and I can see what I was doing wrong now. Thank you!

Idos Over a year ago

@rlfrick Glad it worked, please consider accepting the answer

Idos · Accepted Answer · 2016-02-13 20:42:26Z

0

You won't exit the while x == 0: loop until x is equal to True. Because 0 == x

edited Feb 13, 2016 at 20:42

Idos

15.3k14 gold badges63 silver badges81 bronze badges

answered Feb 13, 2016 at 20:34

thylong

32 bronze badges

Collectives™ on Stack Overflow

Random.randint not generating a random number in Python

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related