Java code doesn't run when subtracting from an int

Question

    for (i=1; i < 9; i++) {
        for (j=1; j < 9; j++) {
            if ( board[i][j] == "o" ) {
                j = j-1;

                if ( board[i][j] == "x" ) {
                    do {
                        j--;
                    }
                    while (board[i][j] != "-");
                    board[i][j] = ".";
                }
            }
        }
    }

I have this piece of code as part of a method, there are two versions, one as written above and one where j = j-1 is replaced with j = j+1 and j-- is replaced with j++

The positive version works perfectly fine but if I put in the negative version, the code compiles fine but when I attempt to run it nothing happens, the console just hangs and I have to close and reopen it. Can anyone tell me what I am doing wrong? Thanks in advance.

edit:

for (i=1; i < 9; i++) {
        for (j=1; j < 9; j++) {
            if ( board[i][j].equals("o") ) {
                j = j-1;

                if ( board[i][j].equals("x") ) {
                    do {
                        j--;
                    }
                    while (!board[i][j].equals("-"));
                    board[i][j] = ".";
                }
            }
        }
    }

I have edited the code as indicated but the problem persists

Your code as-is is incorrect. And this is probably related to comparing Strings. You need to fix this and debug. — Tunaki
– Tunaki, Commented Feb 14, 2016 at 22:05
You also have a trailing ; here while (!board[i][j].equals("-"));. I suggest you restart and try to make a minimal reproducible example. Please read How to Ask. — Tunaki
– Tunaki, Commented Feb 14, 2016 at 22:16
Thanks cricket_007 MCEmperor and RichardTingle this was the problem, very silly mistake on my part thanks for the help — Haruk20
– Haruk20, Commented Feb 14, 2016 at 22:32

user207421 · Accepted Answer · 2016-02-14 22:33:00Z

1

Your logic is wrong. You're never changing the square that contains "x", so you keep encountering it, so you keep decrementing j, so you will encounter it again next time, so ...

answered Feb 14, 2016 at 22:33

user207421

312k45 gold badges324 silver badges493 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Haruk20 Over a year ago

you're right I was attempting to find the space next to the one with the "x" but didn't realise i was creating the infinite loop by using the same variables in my a for loop and my while loop. Thanks

Collectives™ on Stack Overflow

Java code doesn't run when subtracting from an int

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related