How to declare a variable in header file to be used in two .cpp?

Question

My target module is an executable to be built from X.cpp and Y.cpp, both these two files need a common .h file:

extern HANDLE hPipe;
extern IMediaSample *pSave = NULL;

But when I build the module, I got an error saying :

Y.obj : error LNK2005: "struct IMediaSample * pSave" (?pSave@@3PAUIMediaSample@@A) already defined in X.obj

How to solve this issue?

kennytm · Accepted Answer · 2010-08-23 15:04:48Z

14

extern IMediaSample *pSave = NULL;

This is not just a declaration. This will define pSave to NULL. Since both .cpp include the .h, this variable will be defined in 2 translation units, which causes the conflict.

You should just rewrite it as

extern IMediaSample *pSave;

in the .h, then add IMediaSample *pSave = NULL; in exactly one of the .cpps.

answered Aug 23, 2010 at 15:04

kennytm

526k110 gold badges1.1k silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Numenor · Accepted Answer · 2010-08-23 15:03:57Z

0

try using ifndef statement. define a variable unique to each header file you create then while including use something like:

#ifndef commonh
include common.h
#endif

answered Aug 23, 2010 at 15:03

Numenor

1,70612 silver badges20 bronze badges

1 Comment

Georg Fritzsche Over a year ago

Include guards protect you from including a header multiply in the same source file, not in different ones.

Collectives™ on Stack Overflow

How to declare a variable in header file to be used in two .cpp?

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related