rubocop app controller function validate param integer use of nil? predicate

Question

I tried rewriting this function numerous ways to get around this error, however, I want to defer to other experts before I disable the cop around it.

  def numeric?(obj)
    obj.to_s.match(/\A[+-]?\d+?(\.\d+)?\Z/) == nil ? false : true
  end

This is used like so:

  def index
    if params[:job_id] && numeric?(params[:job_id])

This issue was solved via: Checking if a variable is an integer

Update trying:

  def numeric?(string)
    !!Kernel.Float(string)
  rescue TypeError, ArgumentError
    false
  end

Reference How do I determine if a string is numeric?

New error:

aarontc · Accepted Answer · 2016-02-19 19:16:08Z

1

def numeric?(arg)
  !/\A[+-]?\d+\z/.match(arg.to_s).nil?
end

Passes all Rubocop tests from a default configuration. Complete gist with tests at https://gist.github.com/aarontc/d549ee4a82d21d263c9b

answered Feb 19, 2016 at 19:16

aarontc

284 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Eli Foster · Accepted Answer · 2016-02-19 07:43:13Z

1

The following code snippet does the trick:

def numeric?(arg)
  return false if arg.is_a?(Float)
  return !Integer(arg).nil? rescue false
end

Returns false for the following: 'a', 12.34, and '12.34'.

Returns true for the following: '1', 1.

answered Feb 19, 2016 at 7:43

Eli Foster

687 bronze badges

Comments

Arup Rakshit · Accepted Answer · 2016-02-19 04:58:23Z

0

You can write the method

def numeric?(obj)
  obj.to_s.match(/\A[+-]?\d+?(\.\d+)?\Z/).nil?
end

You really don't need to do nil comparisons and then based on the decision returning true/false. #nil? method does it for you.

answered Feb 19, 2016 at 4:58

Arup Rakshit

119k30 gold badges270 silver badges328 bronze badges

7 Comments

Chris Hough Over a year ago

when integer params are passed i.e. "8" it returned false

Arup Rakshit Over a year ago

Ok, that is because of your regex. The answer was to address the rubocop error. To check the object is a Integer or not, you may try ruby-doc.org/core-2.3.0/Kernel.html#method-i-Integer

Chris Hough Over a year ago

well, the other answer does both, is there a way to incorporate both? I would prefer to use regex in this case, it seems much easier

Arup Rakshit Over a year ago

Why not try already attempted code ? stackoverflow.com/questions/5661466/… :D stackoverflow.com/questions/26061584/…

Chris Hough Over a year ago

I ignored the cop after this chat, seems appropriate

|

Collectives™ on Stack Overflow

rubocop app controller function validate param integer use of nil? predicate

3 Answers 3

Comments

Comments

7 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related