problem calling a php method from within itself

Question

class styleFinder{

function styleFinder(){

}

function getFilesNFolders($folder){

    $this->folder = $folder ;
    if($this->folder==""){
        $this->folder = '.';
    }
    if ($handle = opendir($this->folder)) {
        while (false !== ($file = readdir($handle))) {
            if ($file != "." && $file != "..") {
                echo "$file<br /> ";
                if(is_dir($file)){

                    echo "<b>" . $file . " is a folder</b><br />&nbsp;&nbsp;&nbsp;with contents ";
                    $this::getFilesNFolders($file);
                   # echo "Found folder";
                }
            }
        }
        closedir($handle);
    }
}

} I wan to print out a complete tree of folders and files, the script is going into the first folders and finding the files, then finding any sub folders, but not subfolders of those (and yes there is some). Any ideas please?

Why the ::? Use $this->getFilesNFolders($file); for one thing. — user229044
– user229044 ♦, Commented Aug 24, 2010 at 20:02
Static calls are made using self::method() or parent::method(), but you can't reference object state in a static call (-> is not allowed). Think of static calls as being functional: en.wikipedia.org/wiki/Functional_programming — cbednarski
– cbednarski, Commented Aug 24, 2010 at 20:14
Except that parent::method() is not actually a static call. It's a call that depends on the access type of the original method (if the original was accessed as an instance, then the parent call will have access to $this). So that's a special case (and a non-intuitive one to say the least)... — ircmaxell
– ircmaxell, Commented Aug 24, 2010 at 20:18

FallenAvatar · Accepted Answer · 2010-08-24 20:02:27Z

7

$this::getFilesNFolders($file);

Should Be

$this->getFilesNFolders($file);

answered Aug 24, 2010 at 20:02

FallenAvatar

4,0791 gold badge24 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mchl · Accepted Answer · 2010-08-24 20:02:50Z

6

Since PHP 5.1.2 you have this usefull class available: http://www.php.net/manual/en/class.recursivedirectoryiterator.php

answered Aug 24, 2010 at 20:02

Mchl

62.4k9 gold badges121 silver badges121 bronze badges

Comments

SeanWM · Accepted Answer · 2013-03-08 20:33:10Z

2

Accessing a class function is done like this:

$this->functionName():

edited Mar 8, 2013 at 20:33

SeanWM

17.1k10 gold badges54 silver badges85 bronze badges

answered Aug 24, 2010 at 20:04

2ndkauboy

9,4033 gold badges34 silver badges67 bronze badges

Comments

Gordon · Accepted Answer · 2010-08-24 20:32:25Z

1

Since no one provided that yet, here is the RecursiveDirectoryIterator version of your code:

$iterator = new RecursiveIteratorIterator(
    new RecursiveDirectoryIterator('/path/to/directory'),
        RecursiveIteratorIterator::SELF_FIRST);

foreach($iterator as $fileObject) {
    if($fileObject->isDir()) {
        echo "<strong>$fileObject is a folder:</strong><br>\n";
    } else {
        echo $fileObject, "<br>\n";
    }
}

answered Aug 24, 2010 at 20:32

Gordon

318k76 gold badges548 silver badges566 bronze badges

1 Comment

Phil Over a year ago

Thanks Gordon, much more than I'd expected, I had no idea these existed! Thanks everyone else for chipping in too.

SeanWM · Accepted Answer · 2013-03-08 20:33:41Z

As others have said, within the method itself, you need to call getFilesNFolders with $this -> getFilesNFolders($file). Also, the way the code is posted you're missing a } at the end, but since there is one starting the text after the code, that is probably a typo. The code below worked for me (I ran via the command line, so added code to indent different directory levels and also to output \n's):

<?php

class StyleFinder{
function StyleFinder(){
}

function getFilesNFolders($folder, $spaces){

    $this->folder = $folder ;
    if($this->folder==""){
        $this->folder = '.';
    }
    if ($handle = opendir($this->folder)) {
        while (false !== ($file = readdir($handle))) {
            if ($file != "." && $file != "..") {
                if(is_dir($file)){
                    echo $spaces . "<b>" . $file . " is a folder</b><br/>&nbsp;&nbsp;&nbsp;with contents:\n";
                    $this -> getFilesNFolders($file, $spaces . "  ");
                } else {
                    echo $spaces . "$file<br />\n";
                }
            }
        }
        closedir($handle);
    }
}
}

$sf = new StyleFinder();
$sf -> getFilesNFolders(".", "");

?>

Collectives™ on Stack Overflow

problem calling a php method from within itself

5 Answers 5

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related