addClass on each input validating wrong in jQuery

Question

I have a syntax error - I'm trying to add a class of 'error' if the input fields are blank. It's seems the error class is being applied even if the input fields have text, the logic looks correct to me. Can someone please assist?

$('input').each(function() {
    if($(this).val() == "") {
        $("input").addClass("error");
       return false;
    }
});

Initially they must have been left blank, that time the class is applied. But nothing happens after that. Did you forgot to apply class after text is entered ? — user2705585
– user2705585, Commented Feb 27, 2016 at 14:34

Rajaprabhu Aravindasamy · Accepted Answer · 2016-02-27 14:42:02Z

1

Try to use $(this) to while invoking .addClass(),

$('input').each(function() {
    if($(this).val() == "") {
        $(this).addClass("error");
    }
});

Or the best approach would be using using .filter(),

$('input').filter(function(){ 
   return this.value.trim() === "";
}).addClass("error");

edited Feb 27, 2016 at 14:42

answered Feb 27, 2016 at 14:33

Rajaprabhu Aravindasamy

67.2k17 gold badges107 silver badges133 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Gene R · Accepted Answer · 2016-02-27 14:33:46Z

1

you should addClass to this, but better use toggleClass to also remove error if input got filled:

$('input').each(function() {
    $(this).toggleClass('error', this.value == "");
});

answered Feb 27, 2016 at 14:33

Gene R

3,7442 gold badges21 silver badges28 bronze badges

Collectives™ on Stack Overflow

addClass on each input validating wrong in jQuery

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related