ASP.NET MVC ActionFilter

Question

Does anybody knows if the OnResultExecuted method from ActionFilterAttribute class is executed even in CATCH block?

ie:

        [CookiesActions]
        public ActionResult Login(Usuarios usuario)
[...]
            return View(new UsersViewModel(sceUsuarios.Usuario,true));
            }
            catch
            {
                return View(new UsersViewModel(new Usuarios(),true));//is OnResultExecuted fired here?
            }
[...]

Peter · Accepted Answer · 2010-08-25 20:49:56Z

11

In short: YES.

You can verify this with a a simple logging action filter.

public class LogAttribute : ActionFilterAttribute
{
    public override void OnActionExecuting(ActionExecutingContext filterContext)
    {
        Log("OnActionExecuting", filterContext.RouteData);
    }

    public override void OnActionExecuted(ActionExecutedContext filterContext)
    {
        Log("OnActionExecuted", filterContext.RouteData);
    }

    public override void OnResultExecuting(ResultExecutingContext filterContext)
    {
        Log("OnResultExecuting", filterContext.RouteData);
    }

    public override void OnResultExecuted(ResultExecutedContext filterContext)
    {
        Log("OnResultExecuted", filterContext.RouteData);
    }


    private void Log(string methodName, RouteData routeData)
    {
        var controllerName = routeData.Values["controller"];
        var actionName = routeData.Values["action"];
        var message = String.Format("{0} controller:{1} action:{2}", methodName, controllerName, actionName);
        Debug.WriteLine(message, "Action Filter Log");
    }

}

If you put the [Log] attribute on your method, you'll see that OnResultExecuted is written to debug even when you swallow the exception.

edited Aug 25, 2010 at 20:49

answered Aug 25, 2010 at 20:39

Peter

12.8k4 gold badges36 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Hermes Trismegistus Over a year ago

This answer is directly from Microsoft Docs. learn.microsoft.com/en-us/aspnet/mvc/overview/older-versions-1/…

Peter Over a year ago

The LogAttribute snippet may have been copied from the docs (I don't remember) but the answer is not. This code is there to demonstrate the answer to the user's question, which is that the OnResultExecuted method is called even from inside a catch block.

Cloudy · Accepted Answer · 2012-04-02 14:06:43Z

2

I don't see why it wouldn't. You are swallowing the error.

Returning out of a catch feels dirty. You could achieve the same thing without returning out of a catch:

   [CookiesActions]
    public ActionResult Login(Usuarios usuario)
    {
     [...]

           Usuarios usarios = new Usuarios();

           try
           {
             ...
             usarios = sceUsuarios.Usuario;

            }
            catch  { /*swallow error*/ }

            return View(new UsersViewModel(usarios ,true));

           [...]

    }

edited Apr 2, 2012 at 14:06

Cloudy

7,5297 gold badges64 silver badges98 bronze badges

answered Aug 25, 2010 at 20:26

Chuck Conway

16.5k11 gold badges62 silver badges102 bronze badges

2 Comments

ozsenegal Over a year ago

I cannot do that,cause i want to execute OnResultExecuted logic only if no exceptions occurs

Chuck Conway Over a year ago

You could store a flag in the HttpContext.Items collection. In the catch you could set the flag. In the OnResultExecuted check for the flag... It's a bit kludgy... but it would work.

Collectives™ on Stack Overflow

ASP.NET MVC ActionFilter

2 Answers 2

2 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related