javascript validation on array not running

Question

I've read through many posts, and tried various options, but my validation check on my JavaScript doesn't seem to be running.

I used this post to try and write a validation check to see if the entered zip code is one one delivered to, but when I run it nothing happens and neither alert shows up. Any help is appreciated.

This is the JavaScript I was using:

    <script type="text/javascript">
function validateZip() {
  var zipCode = $("#zipCode").val();
  var acceptableZipCodes = ["78205","72215","78212",];

if( $.inArray( zipCode, acceptableZipCodes)){
  alert("Yes, we can help!");
    }else{
  alert("Sorry, we don't deliever to your area yet.");
}
}
</script>

This is the form

<form name="zipForm" onsubmit="return(validateForm(zipCode))">
  <input type="text" id="zipCode" name="zipCode"> 
    <input id="user_info" type="submit">
</form>

are you getting any error in your browser developer console? — Srinivasan A
– Srinivasan A, Commented Feb 29, 2016 at 19:30

luk492 · Accepted Answer · 2016-02-29 19:15:08Z

1

function validateZip() {
  var zipCode = document.zipForm.zipCode.value;
  var acceptableZipCodes = ["78205","72215","78212",];

  for (i = 0; i < cars.acceptableZipCodes.length; i++) { 
    if(acceptableZipCodes[i] == zipCode{
     alert("Yes, we can help!");
    }else{
     alert("Sorry, we don't deliever to your area yet.");
    }
  }
}

answered Feb 29, 2016 at 19:15

luk492

3684 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chuck · Accepted Answer · 2016-02-29 19:25:32Z

1

There are 2 mistakes I found. 1, you define the function validateZip, but you didn't call it in the script. 2, inArray() function will be return the position of the value in the array, so when a value doesnt in the array, it will return -1.

I do some changes in the code. Hope it help you.

<form name="zipForm" onsubmit="return(validateZip())">
  <input type="text" id="zipCode" name="zipCode"> 
    <input id="user_info" type="submit">
</form>

<script type="text/javascript">
function validateZip() {
  var zipCode = $("#zipCode").val();
  var acceptableZipCodes = ["78205","72215","78212",];

if( $.inArray( zipCode, acceptableZipCodes) !== -1){
  alert("Yes, we can help!");
    }else{
  alert("Sorry, we don't deliever to your area yet.");
    }
}
</script>

answered Feb 29, 2016 at 19:25

Chuck

1481 silver badge6 bronze badges

1 Comment

Candice Over a year ago

Thank you, this is exactly what I needed!

Mikey · Accepted Answer · 2016-02-29 19:33:37Z

I would use an ID instead of name attribute for your form tag (for a quicker retrieval).

<form id="zipForm">
   <input type="text" id="zipCode" name="zipCode"> 
   <input id="user_info" type="submit">
</form>

Then below, I would do this:

<script>
$(function() {
  // add an event handler to your form (look at adeneo's comment)
  $('#zipForm').on('submit', function(e) {
      // prevent form from submitting
      e.preventDefault();
      // call your function
      validateZip($("#zipCode").val());
  });

  function validateZip(zipCode) {
    var acceptableZipCodes = ["78205", "72215", "78212"];
    // be careful with using $.inArray as the return value for no 
    // matches is -1 (and not false)
    if ($.inArray(zipCode, acceptableZipCodes) != -1) {
      alert("Yes, we can help!");
    } else {
      alert("Sorry, we don't deliever to your area yet.");
    }
  }
});
</script>

Tariq · Accepted Answer · 2016-02-29 19:29:11Z

0

You should check if it's begger than -1:

if($.inArray( zipCode, acceptableZipCodes) > -1)

Here a jsfiddle example: JSFiddle

answered Feb 29, 2016 at 19:29

Tariq

2,8813 gold badges24 silver badges29 bronze badges

1 Comment

Candice Over a year ago

Thanks! I'll go in and add that as well

Collectives™ on Stack Overflow

javascript validation on array not running

4 Answers 4

Comments

1 Comment

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related