VBA IF Then statements using string variables

Question

I am working out a problem for my programming class and was wondering if I could get some help. The code below is supposed to get a discount for specific model numbers (AX1 and SD2) at 10% off. All other inputs are to be discounted at 5%. What happens now with the code is just a flat message box with the original entered price.

Private Sub DiscountCalc_Click()

Dim strModelNum As String
Dim curOrigPrice As Currency
Dim sngRate As Long
Dim curDiscount As Long
Dim curNewPrice As Currency


strModelNum = InputBox("Enter desired model number", "Price Lookup")
strModelNum = UCase(strModelNum)

curOrigPrice = InputBox("Enter the original Price", "Price Lookup")
sngRate = 0.1
curDiscount = 0.05


If strModelNum = "AX1" Then
  curNewPrice = curOrigPrice - (curOrigPrice * sngRate)
Else If strModelNum = "SD2" Then
  curNewPrice = curOrigPrice - (curOrigPrice * sngRate)
Else
    curNewPrice = curOrigPrice - (curOrigPrice * curDiscount)
End If

   MsgBox curNewPrice

End Sub

It seems that you have an excess on one End If. Is this intentional or what? I have edited some lines for you.Thanks! — user5857081
– user5857081, Commented Mar 1, 2016 at 8:59
The extra endif was a result of being inexperienced. Thank you! — Zack Withrow
– Zack Withrow, Commented Mar 1, 2016 at 17:55

Tim Williams · Accepted Answer · 2016-03-01 04:01:16Z

1

Try:

If strModelNum = "AX1" Or strModelNum = "SD2" Then
    curNewPrice = curOrigPrice - (curOrigPrice * sngRate)
Else
    curNewPrice = curOrigPrice - (curOrigPrice * curDiscount)
End If

answered Mar 1, 2016 at 4:01

Tim Williams

169k8 gold badges104 silver badges143 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Scott Craner Over a year ago

Also need to change the two longs to doubles. The long is rounding it to 0

Tim Williams Over a year ago

Good catch - missed that

Brendan Gooden · Accepted Answer · 2016-03-01 04:09:49Z

1

Try this code.

You will need to change Long to Double. Also you can compact your IF statements a little.

Private Sub DiscountCalc_Click()

Dim strModelNum As String
Dim curOrigPrice As Double
Dim sngRate As Double
Dim curDiscount As Double
Dim curNewPrice As Double


strModelNum = InputBox("Enter desired model number", "Price Lookup")
strModelNum = UCase(strModelNum)

curOrigPrice = InputBox("Enter the original Price", "Price Lookup")
sngRate = 0.1
curDiscount = 0.05


If strModelNum = "AX1" Or strModelNum = "SD2" Then
  curNewPrice = curOrigPrice - (curOrigPrice * sngRate)
Else
    curNewPrice = curOrigPrice - (curOrigPrice * curDiscount)
End If

   MsgBox curNewPrice

End Sub

edited Mar 1, 2016 at 4:09

answered Mar 1, 2016 at 4:07

Brendan Gooden

1,5913 gold badges26 silver badges49 bronze badges

Comments

Tygh · Accepted Answer · 2016-03-01 04:14:57Z

1

Let's look here:

Dim strModelNum As String
Dim curOrigPrice As Currency
Dim sngRate As Long
Dim curDiscount As Long
Dim curNewPrice As Currency

By using longs for the discount rates, I think you are asking for trouble.

Dim strModelNum As String
Dim curOrigPrice As Currency
Dim sngRate As Double
Dim curDiscount As Double
Dim curNewPrice As Currency

answered Mar 1, 2016 at 4:14

Tygh

112 bronze badges

1 Comment

Zack Withrow Over a year ago

Changing from Long to Double was all that it needed. Thank you.

Collectives™ on Stack Overflow

VBA IF Then statements using string variables

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related