Callback function is not called only once in Service using $timeout

Question

I'm trying to create a service similar to this example. My code is the following:

app.service('Poller', function ($q, $http, $timeout) {

var notification = {};
notification.poll = function (callback, error) {
    return $http.get('https://someapi.com').then(function (response) {
        if (typeof response.data === 'object') {
            if (callback){
                callback(response.data);
                console.log('tick');
            }
        } else {
            if (error) {
                error(response.data);
            }
        }
        $timeout(notification.poll, 10000);
    });
}

notification.poll();

return notification;
});

And I try to use it in my controller like this:

Poller.poll(
    function(jsonAPI) { 
        console.log(jsonAPI);
    }, 
    function(error) {
        console.log('Error:', error);
    }
);

The data are being fetched correctly but there seems to be two problems.

The callback function is called only once and not according to the $timeout. I added the conditionals in the service for callback end error because without them it throws an error callback is not a function. When I refresh or change the view the callback function is again called.
The $timeout seems to be triggered twice every 10 seconds and not once.

Aren't the arguments the two functions I put in? By the way your answer worked perfectly. — Dimitrios Vythoulkas
– Dimitrios Vythoulkas, Commented Mar 1, 2016 at 22:07

Dmitriy · Accepted Answer · 2016-03-01 21:55:58Z

1

Use

$timeout(function () {
    notification.poll(callback, error);
}, 10000);

instead of

$timeout(notification.poll, 10000);

answered Mar 1, 2016 at 21:55

Dmitriy

3,76518 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Callback function is not called only once in Service using $timeout

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related