Angular javascript minification cause Error: $injector:modulerr Module Error

Question

When I define angular like following, it will cause issue on using minification this javascript, which is Error: $injector:modulerr Module Error.

angular.module('myModule').controller('MyController', function ($scope) {

});

Now, if I write my angular as following, it'll be fine after minification.

angular.module('myModule').controller('MyController', ["$scope", function ($scope) {

}]);

During the minification, the first way will convert the $scope to other variable name, looks like that the issue. Is there a way I can avoid not writing code as the second case?

Pedro Nascimento · Accepted Answer · 2016-03-03 22:45:37Z

2

You can use $inject:

function MyController($scope) {
}

MyController.$inject = ['$scope'];
angular.module('myModule').controller('MyController', MyController);

answered Mar 3, 2016 at 22:45

Pedro Nascimento

14k4 gold badges38 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Andreas Jägle · Accepted Answer · 2016-03-03 22:53:15Z

1

If you have some kind of build-process (or you want to introduce a pretty small one), have a look at the ng-annotate project (https://github.com/olov/ng-annotate). It is a tool that processes your javascript code and helps you avoid repeating yourself. What it does is basically reading the first version of your code and generating an $inject property for you as shown in the answer of Pedro Nascimento.

There are several plugins for grunt, gulp, webpack and so on, but it's also pretty easy to just use this one module if you don't have a build process yet.

answered Mar 3, 2016 at 22:53

Andreas Jägle

12.4k3 gold badges33 silver badges33 bronze badges

Comments

Steeve Pitis · Accepted Answer · 2016-03-03 22:48:32Z

0

You have this for Grunt : https://www.npmjs.com/package/grunt-ng-annotate I'm pretty sure you could find the same thing for webpack/gulp etc...

answered Mar 3, 2016 at 22:48

Steeve Pitis

4,4631 gold badge24 silver badges25 bronze badges

Collectives™ on Stack Overflow

Angular javascript minification cause Error: $injector:modulerr Module Error

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related