Variable array in while

Question

I've searched through the stack for an answer but it seems that I cannot find a solution for the following code:

$servers = array();
while($row = mysql_fetch_array( $result ))
{
   $servers[] = $row['name'] => array('ip' => $row['ip'],'port' => $row['port'],'info' => $row['info'],'purpose' => $row['purpose']),
}

What I'm trying to achieve is fetch all results but I receive the following error:

syntax error, unexpected '=>' (T_DOUBLE_ARROW).

Making it like this gets only the last item:

while($row = mysql_fetch_array( $result )) {
$servers = array(
    $row['name'] => array('ip' => $row['ip'],'port' => $row['port'],'info' => $row['info'],'purpose' => $row['purpose']),
    );
}

That being said, $servers is in the while loop, thus making it index only the last item. I don't know what causes the unexpected => :/

Please stop using mysql_* functions. These extensions have been removed in PHP 7. Learn about prepared statements for PDO and MySQLi and consider using PDO, it's really pretty easy. — Jay Blanchard
– Jay Blanchard, Commented Mar 4, 2016 at 20:18

jszobody · Accepted Answer · 2016-03-04 20:22:07Z

1

It looks like you're trying to do this:

$servers = [];
while($row = mysql_fetch_array( $result )) {
   $servers[$row['name']] =  [
       'ip' => $row['ip'],
       'port' => $row['port'],
       'info' => $row['info'],
       'purpose' => $row['purpose']
   ];
}

That gives you a final $servers array, indexed by server name, with an array of details.

Side note: as Jay commented, you really shouldn't be using mysql functions any longer, really encourage you to check out mysqli or PDO functions instead.

edited Mar 4, 2016 at 20:22

answered Mar 4, 2016 at 20:13

jszobody

29k6 gold badges66 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Martin Spatovaliyski Over a year ago

seems like $servers = array(); did the job. $servers = []; was still calling only 1. I took note on Jay's comment and will take a deep look on it.

jszobody Over a year ago

@MartinSpatovaliyski $servers = array() and $servers = [] are the exact same thing. [] is just shorthand for array().

jszobody Over a year ago

@MartinSpatovaliyski If you'd like me to take a look at it, update your question with your modified code. something isn't right, and I can't tell you what's wrong unless I can see it.

Collectives™ on Stack Overflow

Variable array in while

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related