Casting Warning in C : assignment makes integer from pointer without a cast

Question

I am trying to take input from a user and I don't the exact length of input so therefore I am using malloc and I am splitting char by space between them and just need to print an array but I am getting warning i.e assignment makes integer from pointer without a cast on the following line:

array[i++] = p;

and my whole program is as follows:

#include <stdio.h>
#include <string.h>
#include <stdlib.h>

int main ()
{
  char buf[] ="abc qwe ccd";
  int i;
  char *p;
  char *array=malloc(sizeof(char));
  i = 0;
  p = strtok (buf," ");
  while (p != NULL)
  {
    array[i++] = p;
    p = strtok (NULL, " ");
  }
  for (i=0;i<3; ++i)
    printf("%s\n", array[i]);
  return 0;
}

Can anyone please tell me what is wrong with my code. Thank you.

R Sahu · Accepted Answer · 2016-03-08 05:24:50Z

3

The following assignment is not right.

array[i++] = p;

array[i++] evaluates to type char. p is of type char*.

That's what the compiler is complaining about. Judging by the way you are using array, it needs to be of type char**.

char **array = malloc(sizeof(*array)*20); // Make it large enough for your needs.

answered Mar 8, 2016 at 5:24

R Sahu

207k15 gold badges168 silver badges291 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

BASEER HAIDER JAFRI Over a year ago

Thanx alot. Pointers always kill me :(

R Sahu Over a year ago

@BASEERHAIDER, you are welcome. It takes a bit getting used to.

MikeCAT · Accepted Answer · 2016-03-08 05:24:57Z

2

I guess you wanted to create array of pointers to char instead of array of char.

#include <stdio.h>
#include <string.h>
#include <stdlib.h>

int main (void)
{
  char buf[] ="abc qwe ccd";
  int i;
  char *p;
  /* change type of array from char* to char** */
  char **array=malloc(sizeof(char*) * sizeof(buf)); /* allocate enough memory */
  i = 0;
  p = strtok (buf," ");
  while (p != NULL)
  {
    array[i++] = p;
    p = strtok (NULL, " ");
  }
  for (i=0;i<3; ++i)
    printf("%s\n", array[i]);
  free(array); /* it is good to free whatever you allocated */
  return 0;
}

answered Mar 8, 2016 at 5:24

MikeCAT

75.1k11 gold badges50 silver badges71 bronze badges

Collectives™ on Stack Overflow

Casting Warning in C : assignment makes integer from pointer without a cast

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related