delete command in vb.net

Question

I am working vb.net in visual stdio 2005.
I want to delete a row from my table the tables's name is displayed in listbox, when I press delete button in my app nothing happen's.

 Private Sub cmdDELETE_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles cmdDELETE.Click
        Me.SqlConnection1.Open()
        Dim mycom As SqlCommand
        Dim ra As Integer
        mycom = New SqlCommand("DELETE @PICTUREDATA From pic WHERE 
        (NAME = '+ ListBox1.SelectedItem + ')", Me.SqlConnection1)
        ra = mycom.ExecuteNonQuery()
        MessageBox.Show("ROWS AFFECTED " & ra)
        Me.SqlConnection1.Close()
    End Sub

any help plzz

Can you try executing the query DELETE @PICTUREDATA From pic WHERE (NAME = '+ ListBox1.SelectedItem + ') " - with the Selected item value as passed to the code - directly in the DB and check if that achieves the desired result? The code SEEMS pretty OK..u will need to debug it to really pinpoint where the problem lies.. — Jagmag
– Jagmag, Commented Aug 29, 2010 at 4:45

Albin Sunnanbo · Accepted Answer · 2010-08-29 05:02:28Z

2

If you have copy-pasted the code, there is at least one error with quoting. It should be like this:

mycom = New SqlCommand("DELETE @PICTUREDATA From pic WHERE 
(NAME = '" + ListBox1.SelectedItem + "')", Me.SqlConnection1

But you should really consider using the SqlCommand.Parameters collection to add your input data. Your code is open to SQL injection attacks.

answered Aug 29, 2010 at 5:02

Albin Sunnanbo

47.2k8 gold badges72 silver badges110 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

delete command in vb.net

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related