Ruby "Undefined Method" for class method

Question

Ruby beginner struggling to simply print out the value of this @@people hash to the console

class Person
  #have a first_name and last_name attribute with public accessors
  attr_accessor :first_name 
  attr_accessor :last_name

  #have a class attribute called `people` that holds an array of objects
  @@people = []

  #have an `initialize` method to initialize each instance
  def initialize( first_name, last_name )#should take 2 parameters for first_name and last_name
    #assign those parameters to instance variables
    @first_name = first_name
    @last_name = last_name
    #add the created instance (self) to people class variable
    @@people.push self
  end

  #have a `search` method to locate all people with a matching `last_name`
  def self.search( last_name )
    #accept a `last_name` parameter
    @search_name = last_name
    #search the `people` class attribute for instances with the same `last_name`
    @@people.select {|last_name, value| value == "Smith"}.to_s
    #return a collection of matching instances
  end

  #have a `to_s` method to return a formatted string of the person's name
  def to_s
    #return a formatted string as `first_name(space)last_name`
    self.each { |first_name,last_name| print "#{first_name} #{last_name}" }
  end

  def print_hash
    p @@people
  end

end

p1 = Person.new("John", "Smith")
p2 = Person.new("John", "Doe")
p3 = Person.new("Jane", "Smith")
p4 = Person.new("Cool", "Dude")

#puts Person.search("Smith")
puts Person.print_hash
# Should print out
# => John Smith
# => Jane Smith

Tip: with Ruby arrays, it's a little more idiomatic to use << instead of push, i.e. @@people << self. Also, note that what you're doing will prevent this person from every being garbage collected. This may be fine, but you should know it. — Phrogz
– Phrogz, Commented Mar 13, 2016 at 1:03

Lucas Moulin · Accepted Answer · 2016-03-13 00:59:17Z

20

You defined print_hash as an instance method. To be able to call it like People.print_hash define it this way: def self.print_hash

answered Mar 13, 2016 at 0:59

Lucas Moulin

2,5603 gold badges34 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Ruby "Undefined Method" for class method

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related