Redirect to href if javascript return true

Question

I have a <a> link and a checkbox, I want to redirect to the href only if the javascript returns true (the box is checked)

Here is my code :

My javascript file :

function fb_checkbox() {
    if (document.getElementById("checkAGB").checked == false) {
        document.getElementById('notAccepted').style.display = "block";
        return false;
    }else{
        return true;
    }

In my PHP file :

<a href="'.$loginUrl.'" onclick="fb_checkbox();">Sign in with Facebook</a>

Doesn't work, the javascript is executed but the redirection works even if I don't check the checkbox — smile 22121
– smile 22121, Commented Mar 14, 2016 at 10:12

JP. Aulet · Accepted Answer · 2016-03-14 10:50:31Z

2

Try using this in the javascript:

function fb_checkbox(url) { ... else{ window.location.href = url; }

And in the PHP side:

<a href="'.$loginUrl.'" onclick="fb_checkbox(this.href);return false;">Sign in with Facebook</a>

And it should work.

edited Mar 14, 2016 at 10:50

answered Mar 14, 2016 at 10:14

JP. Aulet

4,4164 gold badges30 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

smile 22121 Over a year ago

This executes the Javascript but even without checking the box, the href is redirected

JP. Aulet Over a year ago

I missed: return false; after onclick function call. The full, functional code:

<input type="checkbox" id="checkAGB"> <a href="http://www.google.com" onclick="fb_checkbox(this.href);return false;">Sign in with Facebook</a>  <div style="display:none" id="notAccepted">Check the checkbox!</div>   <script> 	function fb_checkbox(url) { 	    if (document.getElementById("checkAGB").checked == false) { 	        document.getElementById('notAccepted').style.display = "block"; 	        return false; 	    }else{ 	        window.location.href = url; 	    } 	} </script>

Jakub Matczak · Accepted Answer · 2016-03-14 10:19:20Z

1

You need to add return in onclick attribute's value.

Try this:

<a href="'.$loginUrl.'" onclick="return fb_checkbox();">Sign in with Facebook</a>

Here's working example:

function fb_checkbox() {
    if (document.getElementById("checkAGB").checked == false) {
        document.getElementById('notAccepted').style.display = "block";
        return false;
    }else{
        return true;
    }
  }

<input type="checkbox" id="checkAGB"/>
<div id="notAccepted" style="display:none">Check the checkbox!</div>
<a href="http://google.com" onclick="return fb_checkbox();">Works</a>

edited Mar 14, 2016 at 10:19

answered Mar 14, 2016 at 10:12

Jakub Matczak

15.7k5 gold badges52 silver badges68 bronze badges

Comments

Gulmuhammad Akbari · Accepted Answer · 2016-03-14 10:10:40Z

0

Try like this:

<a href="javascript:void()" onclick="fb_checkbox();">Sign in with Facebook</a>

function fb_checkbox() {
    if (document.getElementById("checkAGB").checked == false) {
        document.getElementById('notAccepted').style.display = "block";
        return false;
    }else{
        window.location.href="<?=$loginUrl?>";
    }

answered Mar 14, 2016 at 10:10

Gulmuhammad Akbari

2,0142 gold badges15 silver badges30 bronze badges

Collectives™ on Stack Overflow

Redirect to href if javascript return true

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related