0

I'm working on a table constructor for one of my larger projects but the variables in the content I'm trying to send to the constructor function evaluate before they are sent. Here is a cut down version of the function that should show my problem:

x = 0;

tableConstructor(["<p>" + x + "</p>", "<div>" + x + "</div>"]);

function tableConstructor (tableContent) {
    for (x = 0; x < 2; x++) {
        window["row" + x] = tableContent[x];

        console.log(window["row" + x]);
    }
}

The output is:

<p>0</p>
<div>0</div>

But what I want is:

<p>0</p>
<div>1</div>

Can anyone help me?

Improve this question

3 Answers 3

Reset to default
3

Use ++x while passing argument or x++ like this "<p>" + (x++) + "<p/>"

Post-increment returns the copy of the original value.

Using increment operators:

var y = 0;

function tableConstructor(tableContent) {
  for (var x = 0; x < 2; x++) {
    window["row" + x] = tableContent[x];
    console.log(window["row" + x]);
  }
}
tableConstructor(["<p>" + y + "<p/>", "<div>" + (++y) + "<div/>"]);
<script src="http://gh-canon.github.io/stack-snippet-console/console.min.js"></script>

Using DOM Api:

var y = 0;
function tableConstructor(tableContent) {
  for (var x = 0; x < tableContent.length; x++) {
    var div = document.createElement('div');
    div.innerHTML = tableContent[x];
    var elem = div.firstChild;
    elem.innerHTML = x;
    var wanted = elem.outerHTML;
    window["row" + x] = wanted;
    console.log(window["row" + x]);
  }
}
tableConstructor(["<p>" + y + "<p/>", "<div>" + y + "<div/>"]);
<script src="http://gh-canon.github.io/stack-snippet-console/console.min.js"></script>

Using Regex(replacing digit):

var y = 0;

function tableConstructor(tableContent) {
  for (var x = 0; x < 2; x++) {
    window["row" + x] = tableContent[x].replace(/\d/, x);
    console.log(window["row" + x]);
  }
}
tableConstructor(["<p>" + y + "<p/>", "<div>" + (++y) + "<div/>"]);
<script src="http://gh-canon.github.io/stack-snippet-console/console.min.js"></script>

Improve this answer
Sign up to request clarification or add additional context in comments.

9 Comments

How about x + 1 instead?
It will work as well..But as you have commented this, is there any other advantage of using x+1 ?
I would say there is no any particular reason, it's just a preference.
++x will increase the value of x by 1. x+1 will not.
Thanks for the quick reply, but that wasn't what I meant. I want the function to evaluate x dynamically and not have it based on what I pass the function when I call it.
|
0

The problem with your own example is that the strings that go into your array are created at that very moment when x is still 0. Changing x afterwards doesn't help much.

Here's one very overengineered example to do things, where there's a seperate x in the loop and inside a "builder":

function createEntryBuilder() {
  // This is a *different* `x` from the one in the for loop.
  var x = 0;
  
  return function(tagName) {
    var tag = document.createElement(tagName);
    tag.innerHTML = x;
    x = x + 1;
    return tag;
  }
}

var builder = createEntryBuilder();

tableConstructor(["p", "div"]);

function tableConstructor (tableContent) {
    for (var x = 0; x < 2; x++) {
        var element = builder(tableContent[x]);
        window["row" + x] = element;
        console.log(window["row" + x]);
        document.body.appendChild(element);
    }
}
p { background: pink; }
div { background: khaki; }

If you want to use the loop's number you could change it up to this:

function createEntryBuilder() {
  return function(tagName, x) {
    var tag = document.createElement(tagName);
    tag.innerHTML = x;
    x = x + 1;
    return tag;
  }
}

var builder = createEntryBuilder();

tableConstructor(["p", "div"]);

function tableConstructor (tableContent) {
    for (var x = 0; x < 2; x++) {
        var element = builder(tableContent[x], x);
        window["row" + x] = element;
        console.log(window["row" + x]);
        document.body.appendChild(element);
    }
}
p { background: pink; }
div { background: khaki; }

Improve this answer

Comments

0

What if you use some kind of template, like this:

function tableConstructor (tableContent) {
    for (var x = 0; x < tableContent.length; x++) {
        window["row" + x] = tableContent[x].replace("{x}",x);
        console.log(window["row" + x]);
    }
}

tableConstructor(["<p>{x}</p>", "<div>{x}</div>", "<i>{x}</i>"]);

This way you can do something like this:

tableConstructor(["<p>hey variable x is {x}</p>", "<div>now is {x}</div>", "<i>and it changed to this {x}</i>"]);
Improve this answer

Comments

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.