AngularJS and JSON returns undefined

Question

Hi I have got a data in LocalStorage as JSON string:

[
     {"Date":"28/04/2016","Time":"08:00","Title":"Title 1"},
     {"Date":"28/04/2016","Time":"08:30","Title":"Title 2"}
]

And my module.factory looks like:

module.factory('$schedule', function() {
        var schedule = {};

        var result = JSON.parse(localStorage.getItem('myAgenda'));

        schedule.items = [{
                title: result.Title,
                date: result.Date,
                time: result.Time           
        }];
        return schedule;
    });

When I am trying to get data it returns undefined. When I try to get a specific object like:

console.log(result[0].Title);

It works fine and shows only the first element. I guess I missing each definition but don't know how to do it. Please help me to get all results in my schedule.items.

And I am passing the result as items into:

module.controller('ScheduleController', function($scope, $schedule) {    
  $scope.items = $schedule.items; 
});

Many thanks.

Is the format correct? [{"Date":"28/04/2016","Time":"08:00","Title":"Title 1"},{"Date":"28/04/2016","Time":"08:30","Title":"Title 2"] or are you missing a }? — Konkko
– Konkko, Commented Mar 15, 2016 at 15:44
Hi @LukaJacobowitz I am using the controller: module.controller('ScheduleController', function($scope, $schedule) { $scope.items = $schedule.items; }); — qqruza
– qqruza, Commented Mar 15, 2016 at 15:46
You should iterate the array, where now you are not doing so, since you got undefined ! — optimus
– optimus, Commented Mar 15, 2016 at 15:46
@qqruza: late to the party! hope you sort it out already from chris answer — optimus
– optimus, Commented Mar 16, 2016 at 6:26

Chris · Accepted Answer · 2016-03-15 16:06:45Z

1

You are trying to access fields in an array without mentioning wich array element you want to access. If you want to enumerate all agenda entries and add them to your array, it should look something like this:

module.factory('$schedule', function () {
    var schedule = [];

    var result = JSON.parse(localStorage.getItem('myAgenda'));

    result.forEach(function (date) {
        schedule.push({
            title: date.Title,
            date: date.Date,
            time: date.Time
        })
    })

    return schedule;
});

edited Mar 15, 2016 at 16:06

answered Mar 15, 2016 at 15:47

Chris

3,3481 gold badge35 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

qqruza Over a year ago

I have got an error: Cannot read property 'push' of undefined

Chris Over a year ago

If you look at the line of code "var schedule = {};" i changed it into "var schedule = [];" wich indicates an empty array instead of an empty object. That way you'll be able to use push!

qqruza Over a year ago

I have done this change but still receive the error TypeError: Cannot read property 'push' of undefined pointing to this line: schedule.items.push({

Chris Over a year ago

My appolegies, schedule.push({ it has to be and not schedule.items.push({

qqruza Over a year ago

Thanks a million @Chris

|

Pankaj Parkar · Accepted Answer · 2016-03-15 15:45:44Z

1

You should use .map over array, also add missing } in your last element of array.

var schedule = [];
//assuming result returns an array.
schedule = result.map(function(value){
   return {
        title: value.Title,
        date: value.Date,
        time: value.Time
   };
})

answered Mar 15, 2016 at 15:45

Pankaj Parkar

136k23 gold badges241 silver badges307 bronze badges

Comments

Christian · Accepted Answer · 2016-03-15 15:44:40Z

0

Not familiar with module.factory, but it looks like result is an array of objects and you're accessing it like a single object when creating schedule.items.

You might have to iterate over the array and create an item per object in result.

answered Mar 15, 2016 at 15:44

Christian

583 bronze badges

Collectives™ on Stack Overflow

AngularJS and JSON returns undefined

3 Answers 3

7 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

7 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related