Javascript - Looping over an array of objects, only last object show

Question

i spent a bit trying to make title that explained the issued but i fear it fell a bit short of the issue i am having.

in short, i am using a for loop to iterate over this array of objects.

var people = [
  {
      name: "John Doe",
      age: 33,
      gender: "male",
      loc: "Springfield"
   },
   {
      name: "Jane Doe",
      age: 32,
      gender: "female",
      loc: "Springfield"
   }
];

The for loop is run through a function passing two arguments, an element id and the array, like this.

var list = {
  html: function (el, array) {
    var container = document.getElementById(el), html;    
    for( var i=0;i<array.length;i++ ) {
      html  = '<div class="item">';
      html +=   '<h1>'+array[i].name+'</h1>';
      html +=   '<p>Age: '+array[i].age+'</p>';
      html +=   '<p>Sex: '+array[i].gender+'</p>';
      html +=   '<p>Location: '+array[i].loc+'</p>';
      html += '</div>';     
      console.log( array[i].name+', '+array[i].age+', '+array[i].gender+', '+array[i].loc );  
    } 
    container.innerHTML = html; 
  } 
}
list.html('list', people);

The problem: The loop returns only the last object in the array. I am unsure why this is happening or how to solve it. Any assistance would be much appreciated. Thank you.

Here is a link to a: relevant demo

u_mulder · Accepted Answer · 2016-03-21 19:57:54Z

9

Init html var with empty string and add + in the beginning of for loop:

var container = document.getElementById(el), html = "";   
for( var i=0;i<array.length;i++ ) {
    html  += '<div class="item">';  // add plus here

edited Mar 21, 2016 at 19:57

answered Mar 21, 2016 at 19:56

u_mulder

54.8k5 gold badges54 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

gen_Eric Over a year ago

Also make sure you do html = '' at the beginning.

Frederick M. Rogers Over a year ago

@u_mulder, Thank you kind sir. I do hate it when the solution stares me in the face. Hva a nice day!

ismaro3 · Accepted Answer · 2016-03-21 19:58:59Z

2

The first instruction inside the foor loop is an assignment

html  = '<div class="item">'

so on every iteration the whole content of "html" gets replaced. You should use

html += '<div class="item">';

answered Mar 21, 2016 at 19:58

ismaro3

791 silver badge5 bronze badges

1 Comment

Frederick M. Rogers Over a year ago

thank you. It never occurred to me that i was replacing the value of my variable. Such a simple mistake, but so easy to fix. Have a nice day.

Collectives™ on Stack Overflow

Javascript - Looping over an array of objects, only last object show

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related