AngularJs empty result

Question

I've got 2 factory functions:

Factories

factory.getCurrEmployee = function()
{
    data = {"api_token": authenticationFactory.getToken()};
    url = GLOBALS.url + 'show/employee/' + $cookieStore.get('employeeid');
    return requestFactory.post(url, data)
        .then(function (response) {
            return response.data.result.Employee;
        }, function () {
            $window.location.assign('/');
        });
}

factory.isSuperadministrator = function() {
    factory.getCurrEmployee().then(function (employee) {
        if(employee.Role == 'Superadministrator')
        {
            return true; //console.log('Superadministrator')    <- that console.log is visible in my console
        }
        return false;
    });
}
return factory;

In my controller I would expect true or false (a user is a Superadministrator or not) but the result is nothing. If I console.log in my factory.isSuperadministrator the result is true.

Controller

console.log(employeeFactory.isSuperadministrator());

Why is this not working?

@ste2425 those Boolean value's will never get returned untill, promise gets returned. because boolean has been return from callback function. — Pankaj Parkar
– Pankaj Parkar, Commented Mar 24, 2016 at 15:30
@PankajParkar Yes, but the fact the OP has no use of .then in his calling controller code but is returning the expected value in the service callback shows an underlying lack of knowledge on how promise chaining works. Which is why i said he's returning a promise not the value in his callback. — ste2425
– ste2425, Commented Mar 24, 2016 at 15:33
@ste2425 apology.. I misunderstood it. though cheers..I think, OP got what he wanted :-) — Pankaj Parkar
– Pankaj Parkar, Commented Mar 24, 2016 at 15:36

Community · Accepted Answer · 2017-05-23 11:50:32Z

4

Missed to return promise from factory.getCurrEmployee in factory.isSuperadministrator function. Also I did small refactoring which makes your code more smarter.

factory.isSuperadministrator = function() {
    return factory.getCurrEmployee().then(function (employee) {
        return employee.Role == 'Superadministrator';
    });
}

But above thing doesn't solve your problem, it will only print promise object in console. To solve your problem further you need to put .then function with callback over promise returned by employeeFactory.isSuperadministrator() like below

Controller

employeeFactory.isSuperadministrator().then(function(data){
   console.log(res);
});

Do follow same guidelines which are described here in this answer

edited May 23, 2017 at 11:50

CommunityBot

11 silver badge

answered Mar 24, 2016 at 15:25

Pankaj Parkar

136k23 gold badges241 silver badges307 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

ste2425 Over a year ago

Would still need .then in calling controller code.

Pankaj Parkar Over a year ago

@ste2425 could you look at referenced answer

ste2425 Over a year ago

That wasn't in your answer when i commented.

Jamie Over a year ago

@PankajParkar Thanks again. But now I've to do the if statement in every controller again and again right?

Pankaj Parkar Over a year ago

@jamie that is how you should deal with promise(asynchronous) code.. Its regular pattern you should follow. Thanks :-)

scottjustin5000 · Accepted Answer · 2016-03-24 15:28:44Z

0

Try

employeeFactory.isSuperadministrator().then(function(res){
console.log(res);
});

answered Mar 24, 2016 at 15:28

scottjustin5000

1,35612 silver badges10 bronze badges

Collectives™ on Stack Overflow

AngularJs empty result

2 Answers 2

5 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related