Shell Script error: command not found

Question

Here is my code aiming to diff .in and .out file in batches. Both .in and .out files are in same directory and sorted by name. So, two files needed to test should be adjacent in directory. But when I want to use outFile=${arr[$(i++)]} to get the .out file, it shows i++: command not found. What's the error in my script?

#!/bin/sh

dir=$PATH
arr=($dir/*)

for((i=0;i<${#arr[@]};i++));do
        inFile=${arr[$i]}
        outFile=${arr[$(i++)]}
        if diff $inFile $outFile > /dev/null; then
                echo Same
        else
                echo $inFile
        fi
done

PATH is (nearly always) not a single directory, but a colon-separated list of directories. — chepner
– chepner, Commented Apr 1, 2016 at 14:26

Martin Tournoij · Accepted Answer · 2016-04-01 00:24:34Z

4

Use $(( i++ )). That's two (not one) parenthesis.

$( ) runs shell commands.
$(( )) evaluates arithmetic expressions.

Also:

Your script uses bash features (arrays), it's best to use #!/bin/bash to avoid confusion.
I'm not sure what you expect dir=$PATH to do? $PATH is a special environment variable that is used for the lookup of commands. This is probably not what you want, if I understand the intent of the script correctly.
i++ will increment the value after being used; so here inFile and outFile are in fact the same! You probably want to use ++i (which will modify the variable and then use it), or just i + 1 (which will not modify the variable).

edited Apr 1, 2016 at 0:24

answered Apr 1, 2016 at 0:11

Martin Tournoij

28k24 gold badges110 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

chepner Over a year ago

i++ also means you're modifying i in two places; just use $(( i + 1)) for outFile, and use i+=2 in the for loop to iterate over two files at a time.

glenn jackman · Accepted Answer · 2016-04-01 16:27:03Z

1

The stuff in brackets is already evaluated in arithmetic context, like within $(( ... )). So you can do:

for (( i=0; i < ${#arr[@]}; ));do
    inFile=${arr[i++]}
    outFile=${arr[i++]}

References:
https://www.gnu.org/software/bash/manual/bashref.html#Arrays

The subscript is treated as an arithmetic expression ...

https://www.gnu.org/software/bash/manual/bashref.html#Shell-Arithmetic

Within an expression, shell variables may also be referenced by name without using the parameter expansion syntax.

answered Apr 1, 2016 at 16:27

glenn jackman

249k42 gold badges233 silver badges362 bronze badges

Collectives™ on Stack Overflow

Shell Script error: command not found

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related