invalid types 'int[int]' for array subscript

Question

This following code gets this compile error: "invalid types 'int[int]' for array subscript". What should be changed?

#include <iostream>

using namespace std;

int main(){

    int myArray[10][10][10];
    
    for (int i = 0; i <= 9; ++i){
        for (int t = 0; t <=9; ++t){            
            for (int x = 0; x <= 9; ++x){
                for (int y = 0; y <= 9; ++y){

                myArray[i][t][x][y] = i+t+x+y; //This will give each element a value

                      }
                      }
                      }
                      }
    
    for (int i = 0; i <= 9; ++i){
        for (int t = 0; t <=9; ++t){
            for (int x = 0; x <= 9; ++x){
                for (int y = 0; y <= 9; ++y){
                
                cout << myArray[i][t][x][y] << endl;

                    }
                    }
                    }                
                    }
                    
    system("pause");

}

coppro · Accepted Answer · 2008-12-12 19:28:15Z

19

You are subscripting a three-dimensional array myArray[10][10][10] four times myArray[i][t][x][y]. You will probably need to add another dimension to your array. Also consider a container like Boost.MultiArray, though that's probably over your head at this point.

answered Dec 12, 2008 at 19:28

coppro

14.6k5 gold badges62 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user33061 Over a year ago

dammit, I must have accidentally deleted that line earlier on before i started trying to run it.

jmucchiello · Accepted Answer · 2008-12-12 20:00:41Z

7

What to change? Aside from the 3 or 4 dimensional array problem, you should get rid of the magic numbers (10 and 9).

const int DIM_SIZE = 10;
int myArray[DIM_SIZE][DIM_SIZE][DIM_SIZE];

for (int i = 0; i < DIM_SIZE; ++i){
    for (int t = 0; t < DIM_SIZE; ++t){            
        for (int x = 0; x < DIM_SIZE; ++x){

answered Dec 12, 2008 at 20:00

jmucchiello

19k7 gold badges44 silver badges62 bronze badges

1 Comment

Steve Jessop Over a year ago

Just in case in future you have a different number of fingers ;-)

Remy Lebeau · Accepted Answer · 2020-04-17 01:13:51Z

5

Just for completeness, this error can happen also in a different situation: when you declare an array in an outer scope, but declare another variable with the same name in an inner scope, shadowing the array. Then, when you try to index the array, you are actually accessing the variable in the inner scope, which might not even be an array, or it might be an array with fewer dimensions.

Example:

int a[10];  // a global scope

void f(int a)   // a declared in local scope, overshadows a in global scope
{
  printf("%d", a[0]);  // you trying to access the array a, but actually addressing local argument a
}

edited Apr 17, 2020 at 1:13

Remy Lebeau

609k36 gold badges516 silver badges875 bronze badges

answered Jan 27, 2020 at 2:42

Vishal Gupta

711 silver badge1 bronze badge

1 Comment

php_nub_qq Over a year ago

Just wanted to let you know, you saved me hours, thanks!

thkala · Accepted Answer · 2012-01-07 00:59:50Z

3

int myArray[10][10][10];

should be

int myArray[10][10][10][10];

edited Jan 7, 2012 at 0:59

thkala

86.9k24 gold badges167 silver badges205 bronze badges

answered Dec 12, 2008 at 19:30

Cadoo

8255 silver badges13 bronze badges

Comments

thkala · Accepted Answer · 2012-01-07 01:00:10Z

2

You're trying to access a 3 dimensional array with 4 de-references

You only need 3 loops instead of 4, or int myArray[10][10][10][10];

edited Jan 7, 2012 at 1:00

thkala

86.9k24 gold badges167 silver badges205 bronze badges

answered Dec 12, 2008 at 19:28

DShook

15.9k9 gold badges49 silver badges57 bronze badges

Comments

ABHISHEK YADAV · Accepted Answer · 2018-02-04 17:25:41Z

1

I think that you had intialized a 3d array but you are trying to access an array with 4 dimension.

answered Feb 4, 2018 at 17:25

ABHISHEK YADAV

212 bronze badges

1 Comment

Andrei Tudor Diaconu Over a year ago

My advice when giving answers is to try and point to specific parts of the original code from the question. In your case it would mean including int myArray[10][10][10]; for the 3-dimensional array reference and myArray[i][t][x][y] = i+t+x+y; for thr 4-domensional array reference. Sometimes people will downvote if they don't have a context to understand your answer.

Amir M. Mohamadi · Accepted Answer · 2022-04-27 17:47:39Z

0

I just forgot to put [] to the function parameter with array data type like this:

🚨 Instead of this:

void addToDB(int arr) {
    // code
}

✅ Do this:

void addToDB(int arr[]) {
    // code
}

answered Apr 27, 2022 at 17:47

Amir M. Mohamadi

1,57015 silver badges21 bronze badges

Collectives™ on Stack Overflow

invalid types 'int[int]' for array subscript

7 Answers 7

1 Comment

1 Comment

1 Comment

Comments

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

1 Comment

1 Comment

1 Comment

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related