Building a custom class in c#

Question

I haven't made a custom class before so this might not be possible, I want to read a number of text files and store certain information about them to be used throughout my program.

class text
    {
        public int IDnum { get; set; }
        public string file { get; set; }
        public int lineNum { get; set; }
        public string FileText { get; set; }
        public string lineType { get; set; }
    }

    List<text> listOne = new List<text>();
    internal void ReadFile()
    {
        try
        {
            int IDtype = 0;
            foreach (string x in resultFiles)
            {
                using (StreamReader sr = new StreamReader(x))
                {
                    string s;//text line

                    int LINECOUNT = 0;
                    string type = "not defined";
                    while ((s = sr.ReadLine()) != null)// this reads the line
                    {
                        if(s.Contains("COMPUTERNAME="))
                        {
                            type = "PC Name";
                        }

                        if (s.Contains("Original Install Date:     "))
                        {
                            type = "Original Install Date";
                        }
                        if (LINECOUNT==2)
                        {
                            type = "other Date";
                        }
                        if (s.Contains("DisplayName\"="))
                        {
                                type = "Add/Remove Programs";
                        }

                        text text1 = new text { IDnum = IDtype,  lineNum=LINECOUNT, file=x, FileText=s, lineType=type}; 
                        LINECOUNT++;
                        IDtype++;
                        listOne.Add(text1);
                    }

                    sr.Close();
                }
            }
            foreach(var x in listOne)
            {
                MessageBox.Show(x.ToString());
            }
        }
        catch (Exception ex)
        {
            MessageBox.Show(ex.ToString());
        }
    }

However when I try to read the list it just returns the same value "names of program.name of class.text"

I have never built custom classes before can anyone point me to a website where I can learn more examples?

Thanks in advance for any advice :)

You need to override the .ToString()-Method in your text-class to get a proper result when calling x.ToString(). What result do you expect when calling ToString()? — Camo
– Camo, Commented Apr 5, 2016 at 8:24

fubo · Accepted Answer · 2016-04-05 08:28:15Z

3

x.ToString() doesn't work because it's a type of your class and not string.

you can access the properties of the item

foreach (var x in listOne)
{
    MessageBox.Show(x.file + " " + x.FileText);
}

or override the ToString() method in your class - then you can use x.ToString()

class text
{
    public int IDnum { get; set; }
    public string file { get; set; }
    public int lineNum { get; set; }
    public string FileText { get; set; }
    public string lineType { get; set; }

    public override string ToString()
    {
        return string.Format("{0}, {1}", this.file, this.FileText);
    }
}

edited Apr 5, 2016 at 8:28

answered Apr 5, 2016 at 8:26

fubo

46.2k20 gold badges109 silver badges139 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Tim Schmelter Over a year ago

... or override ToString in text (OP should chose another name which is conform to .NET capitalization conventions like Text).

fubo Over a year ago

@TimSchmelter thanks, i had a argumentation about overriding ToString yesterday so i didnt want to mention it first stackoverflow.com/questions/36398000/…

Tim Schmelter Over a year ago

however, instead of ToString and reflection i'd prefer this approach for that task.

scher · Accepted Answer · 2016-04-05 08:27:42Z

1

To use the ToString() method you have to override it e.g. in the following way:

class text
{
    public int IDnum { get; set; }
    public string file { get; set; }
    public int lineNum { get; set; }
    public string FileText { get; set; }
    public string lineType { get; set; }

    public override ToString()
    {
        return fileText; // return here whatever you want to use
    }
}

You use the ToString() to get information about your Test class instances. You will get a better result, if you implement the ToString like above, or use a property of the class.

answered Apr 5, 2016 at 8:27

scher

1,9532 gold badges21 silver badges43 bronze badges

Comments

Guy · Accepted Answer · 2016-04-05 08:31:09Z

1

listOne is list of the class text, so in the loop you actually print the class name and not the content. You can print the content by calling the members you defined

foreach(var x in listOne)
{
     MessageBox.Show(x.IDnum + " " + x.file + ...);
}

As a side note, class names in C# should start with capital letter.

edited Apr 5, 2016 at 8:31

answered Apr 5, 2016 at 8:25

Guy

51.2k10 gold badges49 silver badges96 bronze badges

Collectives™ on Stack Overflow

Building a custom class in c#

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related