javascript module using closure and a function

Question

This code is my first attempt to create a module which gives the full name when given the nick name. but I am getting undefined in the results and don't know why. Thanks

let nameProper = (function nameProper (nameShort) {
  let names = {
    "fj": "Fred Johnson"
  };
  return function () {
    return names['nameShort'] || nameShort;
  };
}());

let myName = nameProper('fj');

names['nameShort'] || nameShort; why are you stringifying nameShort? you probably want names[nameShort] || nameShort; — Hamms
– Hamms, Commented Apr 12, 2016 at 1:12
when you use ['nameShort'] with quote, it looks for that string — omarjmh
– omarjmh, Commented Apr 12, 2016 at 1:12

Casey Foster · Accepted Answer · 2016-04-12 01:13:43Z

2

const nameProper = (function () {
  const names = {
    fj: "Fred Johnson"
  };

  return function (nameShort) {
    return names[nameShort] || nameShort;
  };
})();

let myName = nameProper('fj');

You need to pass your argument to the inner function, not your closing function that is invoked immediately.

answered Apr 12, 2016 at 1:13

Casey Foster

6,0402 gold badges29 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user4244405 · Accepted Answer · 2016-04-12 01:38:05Z

0

Alternatively:

let nameProper = function(nameShort)
{
    return this.names[nameShort] || nameShort;
}
.bind
({
    names:
    {
        "fj": "Fred Johnson"
    }
});

let myName = nameProper('fj');

answered Apr 12, 2016 at 1:38

user4244405

Collectives™ on Stack Overflow

javascript module using closure and a function

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related