Replace element name with string

Question

Replace an element name in a string fails. replace() doesn't seem working.

var a = 1;

function generateDiv() { 
    a++;
    var firstDiv = $(".firstDiv").html();
    firstDiv.replace("fileName1", "fileName" + a);  
    $('#mainDiv').append(firstDiv);
}

Note that instead of amending the HTML string (which could lead to unexpected changes if you have the name repeated elsewhere in the code) you could just clone() the elements and change the name property of the required element. — Rory McCrossan
– Rory McCrossan, Commented Apr 22, 2016 at 11:22

Pranav C Balan · Accepted Answer · 2016-04-22 11:21:20Z

1

You need to update the variable value, replace() will return the new string and it will not update the variable.

var a = 1;

function generateDiv() {
  a++;
  var firstDiv = $(".firstDiv").html();
  firstDiv = firstDiv.replace("fileName1", "fileName" + a); // update the variable with returned value
  // or do it in single line
  // var firstDiv = $(".firstDiv").html().replace("fileName1", "fileName" + a);  
  $('#mainDiv').append(firstDiv);
}

answered Apr 22, 2016 at 11:21

Pranav C Balan

115k25 gold badges172 silver badges195 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

tanaydin · Accepted Answer · 2016-04-22 11:21:29Z

1

Replace returns replaced string, it is not replaces variable... so please do it like

firstDiv = firstDiv.replace("fileName1", "fileName" + a);

answered Apr 22, 2016 at 11:21

tanaydin

5,32632 silver badges50 bronze badges

Collectives™ on Stack Overflow

Replace element name with string

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related