user input validation java classes

Question

This is my validation for user ID number, when testing, I entered an invalid string with a length less than 10 and it sets the input and doesn't execute the else statement.

The Source Code:

private String phoneNum;

public personalInfo(String phNum) {
    setPhoneNum(phNum);
}

public String getPhoneNum() {
    return phoneNum;
}

public void setPhoneNum(String phNum) {
    if (phoneNum.startsWith("05")&&(phoneNum.length()==10)){
        phoneNum = phNum;
    }
    else throw new IllegalArgumentException ("Invalid Phone Number!");
}

How are you calling this code? Please post a MCVE.

Elliott Frisch
– Elliott Frisch

2016-04-22 14:21:41 +00:00
Commented Apr 22, 2016 at 14:21 — Elliott Frisch
– Elliott Frisch, Commented Apr 22, 2016 at 14:21

ΦXocę 웃 Пepeúpa ツ · Accepted Answer · 2016-04-22 16:29:10Z

1

your method looks like this...

public void setPhoneNum(String phNum) {
    if (phoneNum.startsWith("05")&&(phoneNum.length()==10)){
        phoneNum = phNum;
    }

and there you are not validating the parameter, but the variable phoneNum...

do instead:

public void setPhoneNum(String phNum) {
    if (phNum.startsWith("05")&&(phNum.length()==10)){
        phoneNum = phNum;
    }

edited Apr 22, 2016 at 16:29

answered Apr 22, 2016 at 14:27

ΦXocę 웃 Пepeúpa ツ

48.4k17 gold badges77 silver badges102 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bajal · Accepted Answer · 2016-04-22 14:27:57Z

0

You should be validating the value you that you are getting (phNum) and set it to the member variable phoneNum.

if (phNum.startsWith("05")&&(phNum.length()==10)){
    phoneNum = phNum;
}

answered Apr 22, 2016 at 14:27

Bajal

6,1563 gold badges22 silver badges25 bronze badges

Collectives™ on Stack Overflow

user input validation java classes

The Source Code:

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

The Source Code:

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related