Bash Script not taking FileName as command line argument

Question

I am new in bash.. Here is my code for bash script which will take file name as command line argument Code of file hello is :-

#!/bin/bash    
if ["$1"!= "abcd.txt"]; then
   echo Good
else
   echo Not Good
fi

when i am running

$hello abcd.txt

It's showing

/usr/bin/hello: line 2: [abcd.txt: command not found
Not Good

Where is the problem? Please help me as soon as possible. Thanks in Advance.

heemayl · Accepted Answer · 2016-04-22 16:46:46Z

4

["$1"!= "abcd.txt"] is not syntactically right.

You need spaces after [, before ] and also before !=:

[ "$1" != "abcd.txt" ]

answered Apr 22, 2016 at 16:46

heemayl

42.5k10 gold badges86 silver badges87 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Andreas Louv Over a year ago

To clarify why this is needed you should know that [ is a command and needs ] to be the last argument, while each other part should be an its own argument. These days however [ is for the most part a build in.

Collectives™ on Stack Overflow

Bash Script not taking FileName as command line argument

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related