How to compare text input to multiple strings?

Question

I want the following if statement to compare against multiple strings but when i compare against more than one it gives me the error message that I created. Below is the code which does not work.

The variables are test = 'c3400553' and test2 = 'c3400554'

if (!uname.getText().toString().matches("[cC][0-9]{7}") ||
     !uname.getText().toString().equals(test) ||
     !uname.getText().toString().equals(test2)
    ) {
   uname.setError("Incorrect ID Format");
}

Below is the code which works for one comparison.

String test = "c3400553";
...

if (!uname.getText().toString().matches("[cC][0-9]{7}") ||
         !uname.getText().toString().equals(test)
        ) {
          uname.setError("Incorrect ID Format" );
}

I don't understand what the issue is

Check your conditions. Make sure you use && and || where needed. Also check the usage of ! (not operator). Above all, provide a minimal reproducible example — Idos
– Idos, Commented Apr 24, 2016 at 12:08
The condition in your "multiple string test" will always return true. It's a bit like (x != 1) || (x != 2) where what you really want is (x != 1) && (x != 2).In your case what you probably want is: (!uname.getText().toString().matches("[cC][0-9]{7}") && (!uname.getText().toString().equals(test) && !uname.getText().toString().equals(test2)) ) — Achim Schmitz
– Achim Schmitz, Commented Apr 24, 2016 at 12:17

Vic Seedoubleyew · Accepted Answer · 2016-05-18 15:50:43Z

1

That's because you either need to remove some !, or you need to replace your || by &&.

It depends on what you are trying to achieve. If you want the id to be declared incorrect if it doesn't match the format AND if it is not equal to test AND ALSO not equal to test2, then the solution is this :

if (!uname.getText().toString().matches("[cC][0-9]{7}") && 
    !uname.getText().toString().equals(test) &&
    !uname.getText().toString().equals(test2) ) {

      uname.setError("Incorrect ID Format" );
}

Otherwise, if what you want to do is to check whether uname matches the format, and is NOT equal to test and test2, then the problem is that you need to remove the ! before comparisons with test and test2 :

if (!uname.getText().toString().matches("[cC][0-9]{7}") || 
    uname.getText().toString().equals(test) ||
    uname.getText().toString().equals(test2) ) {

     uname.setError("Incorrect ID Format" );
}

edited May 18, 2016 at 15:50

answered Apr 24, 2016 at 12:11

Vic Seedoubleyew

10.7k6 gold badges61 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to compare text input to multiple strings?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related