Angular return mock $http.get

Question

I am trying to search form that will invoke and return ajax call only if the parameter contains 6 or more characters.

In my controller, I have a simple function.

function getByParam(param) {
    if (param.length >= 6) {
        return $http.get('https://example.com/endpoint/' + param);
    } else {
        return noItems();
    }
}

The trouble is with returning a promise with an empty response set. Whatever I seem to try results in an error.

myController.getByParam(param).success is not a function

Currently I have this as the noItems() function.

function noItems() {

    var promise = Promise(function(resolve, reject) {

        if (true) {
            resolve();
        } else {
            reject();
        }
    }).then(function(){
        var emptyResponse = {success:true, response:{records:[]}}
        return emptyResponse
    });

    return promise
}

I have seen answers involving $httpBackend but this seems like overkill. I have also seen suggestions using $timeout but again, I'm missing something to get it to work.

What have you tried? Have you met any problems with spyOn('$http, 'get')? $httpBackend is not overkill but the recommended way of HTTP mocking in Angular. — Estus Flask
– Estus Flask, Commented Apr 24, 2016 at 15:14
My issue is that it something this trivial shouldn't really require mocking a http request. What I am struggling with is how to return a simple promise with output that would be processed the same way. — PassKit
– PassKit, Commented Apr 24, 2016 at 15:16
The problem I see here is that noItems uses native Promise (is processed asynchronously), while $http uses $q promise (is processed synchronously and depends on digest cycle). And mocking $http request with Promise won't make it processed in the same way. Please, elaborate on the choice of promise implementation. — Estus Flask
– Estus Flask, Commented Apr 24, 2016 at 15:38

Rodrigo Juarez · Accepted Answer · 2016-04-24 15:32:52Z

1

Here I made an example using $q instead of Promise (seems a bit more legible the code Link to the example, also you should try to return an error from the server, if someone makes an http request to your server without using your application it's going to crash, because you were doing the validations of the 6 characters.

If the server does this validation, it should return an error message or something, so you don't have to do that logic on your client side.

I am assuming that the server does not this things and give some advices

answered Apr 24, 2016 at 15:32

Rodrigo Juarez

8831 gold badge7 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

PassKit Over a year ago

Yes - the server will return an error, but I would like to completely avoid the overhead of an unnecessary network request.

Rodrigo Juarez Over a year ago

Ok, you can use my example then, but remember that if that someday the server starts accepting less than 6 parameters you're going to have to change your client side code, that's the problem with having double validations (server and client side), the good thing is that you improve the user experience

PassKit Over a year ago

$q and your code got part-way there. But $q does not have a success method like $http.get so I had to refactor other parts to use then / catch.

Collectives™ on Stack Overflow

Angular return mock $http.get

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related