Update values in database using php

Question

I have displayed the data in a form edit.php and again paas the truk_id in url on update page to update.php the data of the fields but it's not working. Can anyone check this

PHP Code

   <?php
 $truck_id=$_GET['truck_id'];
 print_r($truck_id);
 include("assets/database_con.php");
    if (isset($_POST['submit'])) 
  { 
   $truck_id=$_POST['truck_id'];   
            $truck_number= mysql_real_escape_string(htmlspecialchars($_POST['truck_number']));
            $truck_model= mysql_real_escape_string(htmlspecialchars($_POST['truck_model']));
            $truck_make= mysql_real_escape_string(htmlspecialchars($_POST['truck_make']));
            $truck_type= mysql_real_escape_string(htmlspecialchars($_POST['truck_type']));
            $truck_tierweight= mysql_real_escape_string(htmlspecialchars($_POST['truck_tierweight']));
            $truck_gvm= mysql_real_escape_string(htmlspecialchars($_POST['truck_gvm']));
            $truck_regodate= mysql_real_escape_string(htmlspecialchars($_POST['truck_regodate']));
            $truck_inspectaiondate= mysql_real_escape_string(htmlspecialchars($_POST['truck_inspectaiondate']));
            $sql1 ="UPDATE add_truck SET truck_number='$truck_number', truck_model='$truck_model', truck_make='$truck_make', truck_type='$truck_type', truck_tierweight='$truck_tierweight', truck_gvm='$truck_gvm', truck_regodate='$truck_regodate', truck_inspectaiondate='$truck_inspectaiondate' where truck_id='$truck_id'";
            echo $sql1;
            $results=$conn->query($sql);
        if($results)
        {
            print 'Success! record updated'; 
        }else{
            print 'no! record updated';
        }                   
    }
?>

try echo $sql and execute that sql in phpmyadmin query window and see if the query is correct. — vishwakarma09
– vishwakarma09, Commented Apr 26, 2016 at 5:23
WARNING: Using manual escaping is extremely error prone and a single mistake can lead to a crippling SQL injection bug. Whenever possible use prepared statements. These are quite straightforward to do in mysqli and PDO where any user-supplied data is specified with a ? or :name indicator that’s later populated using bind_param or execute depending on which one you’re using. — tadman
– tadman, Commented Apr 26, 2016 at 5:24

Pupil · Accepted Answer · 2016-04-26 05:29:42Z

1

You are assigning values to fields in single quotes.

The main string is enclosed within single quotes.

Variables inside single quotes are not parsed (value is not calculated).

This is called variable interpolation.

Use double quotes for whole string and single quotes for values.

Corrected SQL:

$sql = "UPDATE add_truck 
        SET truck_number='$truck_number', truck_model='$truck_model', 
        truck_make='$truck_make', truck_type='$truck_type', 
        truck_tierweight='$truck_tierweight', 
        truck_gvm='$truck_gvm', truck_regodate='$truck_regodate',
         truck_inspectaiondate='$truck_inspectaiondate' where truck_id='$truck_id'";

answered Apr 26, 2016 at 5:29

Pupil

24k6 gold badges49 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Pupil Over a year ago

print the sql query using: echo $sql;die(); and post query here.

gavgrif · Accepted Answer · 2016-04-26 05:26:39Z

0

you are using GET for the truck id and POST for all other variables - is this intentional?

$truck_id=$_GET['truck_id'];

should it be

$truck_id=$_POST['truck_id'];

or should all the other variables be from the GET array?

answered Apr 26, 2016 at 5:26

gavgrif

15.5k2 gold badges30 silver badges31 bronze badges

3 Comments

Er Deepesh Tripathi Over a year ago

Using this : <?php $truck_id=$_GET['truck_id']; include("assets/database_con.php"); if (isset($_POST['submit'])) { $truck_id=$_POST['truck_id'];

Er Deepesh Tripathi Over a year ago

thanks brother for being together ,, I just caught the issues and now fixed.

gavgrif Over a year ago

no worries - happy to help. good luck with it.click the upvote if my answer helped you at all. Thanks gav

Sanooj T · Accepted Answer · 2016-04-26 07:01:17Z

0

$truck_id=$_GET['truck_id'];

Here is your problem part you can't get values from get method when you submit. So you need to add some hidden field into your form like this

<input type="hidden" name="truck_id" value="<?php echo $_GET['truck_id']; ?>">

Change your code like this

if (isset($_POST['submit'])) 
  { 
   $truck_id=$_POST['truck_id']; 
  }

I changed your code please look at this

//Your code starts now
 <?php
include("header.php");
include("assets/database_con.php");
$truck_id= $_GET['truck_id'];
//print ($truck_id);
?>
<?php
//submit part in top that is better
 if (isset($_POST['submit']))
{
$truck_id=$_POST['truck_id'];
$truck_number= mysql_real_escape_string(htmlspecialchars($_POST['truck_number']));
$truck_model= mysql_real_escape_string(htmlspecialchars($_POST['truck_model']));
$truck_make= mysql_real_escape_string(htmlspecialchars($_POST['truck_make']));
$truck_type= mysql_real_escape_string(htmlspecialchars($_POST['truck_type']));
$truck_tierweight= mysql_real_escape_string(htmlspecialchars($_POST['truck_tierweight']));
$truck_gvm= mysql_real_escape_string(htmlspecialchars($_POST['truck_gvm']));
$truck_regodate= mysql_real_escape_string(htmlspecialchars($_POST['truck_regodate']));
$truck_inspectaiondate= mysql_real_escape_string(htmlspecialchars($_POST['truck_inspectaiondate']));
$sql1 ="UPDATE add_truck SET truck_number='$truck_number', truck_model='$truck_model', truck_make='$truck_make', truck_type='$truck_type', truck_tierweight='$truck_tierweight', truck_gvm='$truck_gvm', truck_regodate='$truck_regodate', truck_inspectaiondate='$truck_inspectaiondate' where truck_id='$truck_id'";
echo $sql1;
die();
$results=$conn->query($sql);
if($results)
{
    print 'Success! record updated';
}else{
    print 'no! record updated';
}
}
?>

And changed some thing in here(added action="")

 <form role="form" method="post"  action="">

And changed some thing in here also(added name="submit")

<div class="form-group">

<input type="hidden" name="truck_id" value="<?php echo $_GET['truck_id']; ?>">
<input type="submit" value="submit" name="submit" class="btn_full" id="submit-booking">
</div>

No need for another div for hidden because it is 'hidden'

edited Apr 26, 2016 at 7:01

answered Apr 26, 2016 at 5:36

Sanooj T

1,3471 gold badge14 silver badges27 bronze badges

13 Comments

Er Deepesh Tripathi Over a year ago

ok i have checked after echo "$truck_id" vales comes in this page. Let me use your code. thanks..I have checked using this code nth happen ..

Sanooj T Over a year ago

if it helps please let me know

Er Deepesh Tripathi Over a year ago

Should i try this <?php $truck_id=$_GET['truck_id']; print_r($truck_id); include("assets/database_con.php"); if (isset($_POST['submit'])) { $truck_id=$_POST['truck_id'];

Sanooj T Over a year ago

if you want $_POST['truck_id'] you want some input in your form tag so please add <input type="hidden" name="truck_id" value="<?php echo $_GET['truck_id']; ?>"> inside your form tag

Sanooj T Over a year ago

otherwise everything perfect

|

Er Deepesh Tripathi · Accepted Answer · 2016-04-26 07:59:05Z

0

Used a new code as solution :
    <?php
 if (isset($_POST['submit']))
{
$truck_id=$_POST['truck_id'];

...
}

and one hidden value with the submit name of attribute :
<input type="hidden" name="truck_id" value="<?php echo $_GET['truck_id']; ?>">
                                   <input type="submit" value="submit" name="submit" class="btn_full" id="submit-booking">

edited Apr 26, 2016 at 7:59

answered Apr 26, 2016 at 6:45

Er Deepesh Tripathi

291 silver badge7 bronze badges

1 Comment

Er Deepesh Tripathi Over a year ago

I have tried this .. but no error and nothing happeing in updation.

Collectives™ on Stack Overflow

Update values in database using php

4 Answers 4

1 Comment

3 Comments

13 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

3 Comments

13 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related