Python writes empty json file

Question

I'm working on a console app in python. I have a command that should save the program state as a json file, but when I write the file, it's empty. The result of .as_list() here is a list containing an arbitrary 3-lists.

class SaveCommand():

    def __init__(self, console):
        self.console = console

    def execute(self, args):
        if self.console.combat is None:
            raise ConsoleCommandException("there is no active combat")

        if len(args) != 1:
            raise ConsoleCommandException("save [save name]")
        try:
            with open("save_files/" + args[0] + ".json", "w") as outfile:
                json.dumps(self.console.combat.as_list(), outfile)
        except Exception:
            raise ConsoleCommandException("save failed: unknown error")

        print("successfully saved \"" + args[0] + "\"")

Does your program have permission to write to that file?

Drathier
– Drathier

2016-04-27 22:35:19 +00:00
Commented Apr 27, 2016 at 22:35 — Drathier
– Drathier, Commented Apr 27, 2016 at 22:35

TankorSmash · Accepted Answer · 2016-04-27 22:36:05Z

13

json.dumps doesn't write a file, it returns the string serialized as JSON. You're looking for json.dump. Notice the missing fp param for dumps.

answered Apr 27, 2016 at 22:36

TankorSmash

12.9k6 gold badges70 silver badges108 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

guilhermecgs Over a year ago

20 min lost on this one

Collectives™ on Stack Overflow

Python writes empty json file

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related