Break out of a "for" loop within a callback function, in Node.js

Question

Regarding the code below, my goal is to break out of FOR LOOP B and continue with FOR LOOP A, but within a callback function.

for(var a of arrA) {
    // ...
    // ...

    for(var b of arrB) {
        // ...
        // ...

        PartService.getPart(a.id, function(err, returnObj) {
            break;
        });
    }
}

Will this give me the results I want? If not, how can I achieve this?

EDIT 4/28/16 3:28 MST

The callback function is indeed asynchronous

Based on one of the answers and all the comments below, without changing the scope of the question, perhaps the best question at this point is "How do I implement a synchronous callback function in Node.js?". I am considering refactoring my code so to remove for loops, but I am still curious if I can still go in this direction using synchronous callback functions. I know that Underscore.js uses synchronous callback functions, but I do not know how to implement them.

"Will this give me the results I want?" — Have you tried it? — Quentin
– Quentin, Commented Apr 28, 2016 at 18:14
Why does PartService.getPart take a callback in the first place? Is it asynchronous? — Quentin
– Quentin, Commented Apr 28, 2016 at 18:14
break can only be inside a loop. The callback introduces a new boundary so it is not considered inside the for loop. Also, both loops will have run to completion before the callback is executed (assuming it is async). Loops are synchronous, so they don't play well will asynchronous code (in their bodies). It would probably be useful for you to read more about asynchronous code flow in JavaScript first. — Felix Kling
– Felix Kling, Commented Apr 28, 2016 at 18:16
Thanks Felix Kling, yes it is asynchronous. I have never heard of synchronous callback functions. I am actually trying to convert PHP code into JavaScript and it seems I will need to put a little more thought into it. — Brian
– Brian, Commented Apr 28, 2016 at 21:14
This break should give you a runtime error, or just be ignored, because it is not in the loop. — Thevs
– Thevs, Commented Apr 29, 2016 at 6:20

Jakub Rożek · Accepted Answer · 2016-04-28 18:27:31Z

2

You can try something like this, however it will work only when the callback is fired synchronously.

for(var a of arrA) {
  let shouldBreak = false;
  for(var b of arrB) {
    if (shouldBreak)
      break;
   // rest of code
     PartService.getPart(a.id, function(err, returnObj) { // when the callback is called immediately it will work, if it's called later, it's unlikely to work
       shouldBreak = true;
    });

edited Apr 28, 2016 at 18:27

answered Apr 28, 2016 at 18:14

Jakub Rożek

2,13013 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

alexmac Over a year ago

Why the function needs callback, if it does not async?

Felix Kling Over a year ago

@Alexander: .sort, .map, .forEach, .filter all take "callbacks" but are not async. But yeah, the naming / structure of this function seem to indicate that it is async.

alexmac Over a year ago

@FelixKling yes, you're right, I'm not quite correctly formulated my question.

Jakub Rożek Over a year ago

@AlexanderMac, as the Felix pointed out, the function doesn't have to be asynchronous, but in the world of NodeJS, most callbacks stand for async stuff. However I only posted the idea, and marked it is possible only in case it is sync.

Brian Over a year ago

If I wanted to stick with the looping, how would I go about making the callback synchronous? That seems to be the best question without going being the scope of the original question.

Sumeet Kumar Yadav · Accepted Answer · 2016-04-28 18:20:05Z

0

This might not give you expected result . You can use events EventEmitter or async module .

answered Apr 28, 2016 at 18:20

Sumeet Kumar Yadav

13.2k6 gold badges53 silver badges88 bronze badges

Collectives™ on Stack Overflow

Break out of a "for" loop within a callback function, in Node.js

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related