Somethings wrong with my javascript?

Question

I'm trying to make a page that you type in something in the textbox and the page will alert the text in the textbox but look at the function alert it's not working please help!!!

<!DOCTYPE html>
<html>

<head>
  <script>
    function alert() {
      var userInput = document.getElementById("1").value;
      var email = document.getElementsByClassName("gb_b gb_7a gb_R gb_3a").innerHTML;
      window.alert("From: ", +email + " Message: " + userInput);
    }
  </script>
  <base target="_top">
</head>

<body>
  <input id="1" type="text" value="Write what you want the page to say">
  <button onclick="alert()">Enter</button>
</body>

</html>

where is the element with class "gb_b gb_7a gb_R gb_3a" in teh form? — sujivasagam
– sujivasagam, Commented Apr 29, 2016 at 6:30
@gurvinder372, That is a valid syntax! document.getElementsByClassName(names); — Rayon
– Rayon, Commented Apr 29, 2016 at 6:31
this is element is from google docs to get the users email. im trying to make an addon test project — Eddie Costa Domingues
– Eddie Costa Domingues, Commented Apr 29, 2016 at 6:47

Niklesh Raut · Accepted Answer · 2016-04-29 07:14:59Z

2

Rename the custom function into alertFunction() since it is causing conflict with javascript built-in alert() function.

Try the following code:

<script>
    function alertFunction() {
      var userInput = document.getElementById("inputid1").value;
      var email = document.getElementsByClassName("gb_b gb_7a gb_R gb_3a").innerHTML;
      alert("From: " +email + " Message: " + userInput);
    }
</script>
<base target="_top">

<body>
  <input id="inputid1" type="text" value="Write what you want the page to say">
  <button onclick="alertFunction();">Enter</button>
</body>

edited Apr 29, 2016 at 7:14

Niklesh Raut

34.9k17 gold badges82 silver badges112 bronze badges

answered Apr 29, 2016 at 6:32

Mani

9476 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Niklesh Raut · Accepted Answer · 2016-04-29 07:03:36Z

You are calling alert() recursively without any exit condition, as window.alert refers to your implementation of alert() itself. If you look into your console's log you will see call stack exceeded error.

 function alert() {
     var userInput = document.getElementById("1").value;
     var email = document.getElementsByClassName("gb_b gb_7a gb_R gb_3a").innerHTML;
     alert("From: " + email + "Message: " +userInput); //This refers to your alert
}

You should rename the function as suggested in comments or if you want to override the default behaviour of the alert() function then do not call it from inside of your function.

function custom_alert() {
  var userInput = document.getElementById("1").value;
  var email = document.getElementsByClassName("gb_b gb_7a gb_R gb_3a").innerHTML;
  //window.alert("From: ", +email + " Message: " + userInput);
  console.log("From: "+email + " Message: " + userInput);

}

Collectives™ on Stack Overflow

Somethings wrong with my javascript?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related