Javascript Array Push breaks loop?

Question

I have the following Typescript class, with it's Click function, which is triggered by a button click, in my mobile app. The bit of interest is the todoItemTable.read, which goes and gets an array of ToDoItems from my cloud backend. The current code works and spits out the text of 8 todo items, but I want to store the text in an array, so if you see the commented out line where I push into todos, that was how I thought I woula pproach the issue. However, that line of code stos the loop running, so I get the first ToDo item logged twice and then nothing else. The application does't hang and there is no error.

export class HelloWorldModel extends Observable {
  public todos: any[]; 

  constructor() {
    super();
  }

  Click() {
    var client = new MobileServiceClient("https://example.azurewebsites.net");
    console.log("CLIENT");
    var todoItemTable = client.getTable("TodoItem");
    console.log("Table");
    this.todos = [];
    todoItemTable.read<TodoItem>().then(function (results) {
      // results is array of TodoItem-s
      console.log(results.length);
      console.log(results[0].text);
      for (let i of results) {
        console.log(i.text);
        //this.todos.push(i.text);
      }
    });
  }

}

What is going wrong?

try-catch-finally · Accepted Answer · 2016-04-30 20:28:40Z

5

To work with the same scope use arrow functions, like this:

todoItemTable.read<TodoItem>().then((results) => {
  for (let i of results) {
    this.todos.push(i.text);
  }
});

See the Mozilla Developer Network on Arrow functions

edited Apr 30, 2016 at 20:28

try-catch-finally

7,6606 gold badges49 silver badges71 bronze badges

answered Apr 30, 2016 at 12:14

Cesar William Alvarenga

5033 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rohit Poudel · Accepted Answer · 2017-09-08 05:33:20Z

0

I was having this same problem, whenever I tried using array.push() anywhere in my loop it would run through once and then stop. I fixed this problem by instantiating the array as an empty array (array: string[ ] = [ ]) OUTSIDE of my loop. then instantiating the new string to be pushed to the array INSIDE the loop. hope this helps anyone out there =)

edited Sep 8, 2017 at 5:33

Rohit Poudel

1,9072 gold badges21 silver badges24 bronze badges

answered Sep 8, 2017 at 4:33

Jack Asani

111 bronze badge

Collectives™ on Stack Overflow

Javascript Array Push breaks loop?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related