Change password functionality in ASP.NET MVC(unable to fetch value from database)

Question

I am creating an MVC application. I am getting a null value in variable when I fetching data from database.

Here is my change password view code

@using (Html.BeginForm("Changepassword", "Home", FormMethod.Post))
{

       <table class="center">


           <tr>
               <td>Old Password</td>
               <td>
                   @Html.EditorFor(pass => pass.Password)
               </td>
               <td>@Html.ValidationMessageFor(pass => pass.Password)</td>
           </tr>
           <tr class="rowspace">
               <td>New Password</td>

               <td>
                   @Html.EditorFor(pass => pass.NewPassword)
               </td>
               <td>@Html.ValidationMessageFor(pass => pass.NewPassword)</td>
           </tr>

           <tr class="rowspace">
               <td colspan="3" id="button">
                   <input type="submit" value="Change Password" /></td>
           </tr>
           <tr class="rowspace"><td colspan="3">@ViewBag.Message</td></tr>
       </table>

}

Here is my Home controller code.

Problem I am facing - var userDetail is returning null and when i checked and debug my code using breakpoint my login.Email is not fetching email from database and it is returning null.

public ActionResult Changepassword(tblUser login)
{
   using (UserDetailsEntities db = new UserDetailsEntities())
   {
       var detail = db.tblUsers.Where(log => log.Password == login.Password).FirstOrDefault();
       if (detail != null)
       {
           var userDetail = db.tblUsers.FirstOrDefault(c => c.Email == login.Email);


           if (userDetail != null)
           {
               userDetail.Password = login.NewPassword;

               db.SaveChanges();
               ViewBag.Message = "Record Inserted Successfully!";
           }
           else
           {
               ViewBag.Message = "Password not Updated!";
           }

       }
   }

   return View(login);
}

in your view for the model email is not assigned.so it will come as null in tblUser login make a hidden field for the email.. — Sachu
– Sachu, Commented May 1, 2016 at 5:57
And are you really storing your passwords in the database as plain text (not hashed)? — user3559349
– user3559349, Commented May 1, 2016 at 5:58
@Sachu can you explain with code .... as I am very new to MVC and coding.It will be very helpful — Aman Mehta
– Aman Mehta, Commented May 1, 2016 at 6:02
@AmanM two ways of doing it..1. Like you are asking old password ask for the email in the view. Or pass the model from controller and save the email value in a hidden field.I hope first one is the best practice. — Sachu
– Sachu, Commented May 1, 2016 at 6:03
Just add @Html.EditorFor(m => m.Email) in your view and change the controller to var detail = db.tblUsers.Where(x => x.Password == login.Password && x.Email == login.Email).FirstOrDefault(); - the second query is not required — user3559349
– user3559349, Commented May 1, 2016 at 6:04

Sachu · Accepted Answer · 2016-05-01 06:08:10Z

In your view email for the model is not assigning so it will be always null when its get posted. Best practice is to ask for the email also at the time of password change. Check code below Your view

 @using (Html.BeginForm("Changepassword", "Home", FormMethod.Post))
    {
           <table class="center">
             <tr>
                   <td>Email</td>
                   <td>
                       @Html.EditorFor(pass => pass.email)
                   </td>
                   <td>@Html.ValidationMessageFor(pass => pass.email)</td>
               </tr>
               <tr>
                   <td>Old Password</td>
                   <td>
                       @Html.EditorFor(pass => pass.Password)
                   </td>
                   <td>@Html.ValidationMessageFor(pass => pass.Password)</td>
               </tr>
               <tr class="rowspace">
                   <td>New Password</td>

                   <td>
                       @Html.EditorFor(pass => pass.NewPassword)
                   </td>
                   <td>@Html.ValidationMessageFor(pass => pass.NewPassword)</td>
               </tr>

               <tr class="rowspace">
                   <td colspan="3" id="button">
                       <input type="submit" value="Change Password" /></td>
               </tr>
               <tr class="rowspace"><td colspan="3">@ViewBag.Message</td></tr>
           </table>

    }

Controller

 public ActionResult Changepassword(tblUser login)
    {
       using (UserDetailsEntities db = new UserDetailsEntities())
       {
           var detail = db.tblUsers.Where(log => log.Password == login.Password 
           && log.email == login.email).FirstOrDefault();
           if (detail != null)
           {
                   userDetail.Password = login.NewPassword;

                   db.SaveChanges();
                   ViewBag.Message = "Record Inserted Successfully!";

              }
     else
               {
                   ViewBag.Message = "Password not Updated!";
               }


       }

       return View(login);
    }

Collectives™ on Stack Overflow

Change password functionality in ASP.NET MVC(unable to fetch value from database)

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related