echo command with variable and string

Question

I have 3 variables I'm trying to insert into an echo command that contains the string, as well.

Here is what I have:

1= "test1"
2= "test2"
3= "test3"

FileName= "WEATHERMAP"_"$1"_"STATE"_"$2"_"CITY"_"$3" 

echo $FileName

I want it to echo WEATHERMAP_test1_STATE_test2_CITY_test3
Instead I get WEATHERMAP__STATE__CITY_

I know this has something to do with the underscore, unfortunately, I need the underscore.

The only examples I have seen are putting two variables together, or it started with a variable followed by a string.

Also, Variables can also contain digits but a name starting with a digit is not allowed: source link — Kiran Kulkarni
– Kiran Kulkarni, Commented May 5, 2016 at 5:38
There should be no spaces preceding and following the assignment operator. Values should be assigned this way a="test" — Kiran Kulkarni
– Kiran Kulkarni, Commented May 5, 2016 at 5:43
shellcheck.net misses the obvious, but catches the other two errors which none of the answers so far have bothered to point out. In general, use a syntax checker before asking here about basic scripting problems. — tripleee
– tripleee, Commented May 5, 2016 at 9:12

riteshtch · Accepted Answer · 2016-05-05 05:28:54Z

3

Don't start variable names with a number.

$ a="test1"
$ b="test2"
$ c="test3"
$ FileName="WEATHERMAP_${a}_STATE_${b}_CITY_${c}"
$ echo "$FileName"
WEATHERMAP_test1_STATE_test2_CITY_test3
$

edited May 5, 2016 at 5:28

answered May 5, 2016 at 5:19

riteshtch

8,7994 gold badges28 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

buzzin Over a year ago

This is similar to what @anubhava commented, but in my lab the _ after the first variable makes everything after it one long variable.

riteshtch Over a year ago

@buzzin thats why you have to put each variable into curly brackets ${var}

Saravanan Sivam · Accepted Answer · 2016-05-05 05:27:42Z

0

I'm guessing you're using bash by default, in which case letters, numbers and underscores are allowed, but you can't start the variable name with a number. You can achieve by following code :-

a="test1"
b="test2"
c="test3"

FileName="WEATHERMAP"_"$a"_"STATE"_"$b"_"CITY"_"$c"
## Also, can assign as below :
## FileName="WEATHERMAP_${a}_STATE_${b}_CITY_${c}"

echo $FileName

answered May 5, 2016 at 5:27

Saravanan Sivam

492 bronze badges

Comments

Sergey Brodin · Accepted Answer · 2016-05-05 06:24:34Z

0

The numerical variables are reserved for shell internal purposes, $0 contains script filename, $1 - first script argument, like ./script.sh first-argument, $2 - second script argument, etc.

answered May 5, 2016 at 6:24

Sergey Brodin

3611 silver badge7 bronze badges

Collectives™ on Stack Overflow

echo command with variable and string

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related