Non-static private variables in javascript

Question

I'm setting up my javascript objects like the following

Object1 = function() {
  var privateMember = "private value"

  return {
    publicMember: "public value"
    setPrivateMember: function(value) {
       privateMember = value;
    }
  }
}();

Now if I use prototypal inheritance to create new objects

Object2.prototype = Object1

And then set the private member

Object2.setPrivateMember("new value");

Then the value of private member in Object 1 changes too, so it behaves more like a static variable. Is there a way I can get private variables to not be static?

PS - I'm a self-taught programmer so my use of terminology might be a bit sketchy. Let me know if it needs clarifying

Should be using Object2.prototype = Object1(), or is that just a typo in the pasted code? — MooGoo
– MooGoo, Commented Sep 14, 2010 at 14:35
possible duplicate of Private variables in inherited prototypes — TM.
– TM., Commented Sep 14, 2010 at 14:47

Community · Accepted Answer · 2017-05-23 11:48:27Z

3

Righto, knew I awnsered something like this before:
Private variables in inherited prototypes

;oP

edited May 23, 2017 at 11:48

CommunityBot

11 silver badge

answered Sep 14, 2010 at 14:33

BGerrissen

21.7k4 gold badges41 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

wheresrhys Over a year ago

I knew it had to have been asked before, but just couldn't find the right phrase to search for. Cheers for the answer

Kyle Jones · Accepted Answer · 2010-09-14 14:26:52Z

2

You're creating a global variable. Put var before it.

var privateMember = "private value";

answered Sep 14, 2010 at 14:26

Kyle Jones

5363 silver badges5 bronze badges

1 Comment

wheresrhys Over a year ago

This was a typo in my question. Problem still happens even when I use var

Sachin Shanbhag · Accepted Answer · 2010-09-14 14:42:07Z

2

Edited my answer, can you check if this works?

Try this -

Object1 = function() {  
  var privateMember = "private value"; 

  var returnVal =  {  
                publicMember: "public value",  
                setPrivateMember: function(value) {  
                privateMember = value;  
                }

           }; 
  return returnVal; 
}();

edited Sep 14, 2010 at 14:42

answered Sep 14, 2010 at 14:27

Sachin Shanbhag

55.7k11 gold badges92 silver badges103 bronze badges

Collectives™ on Stack Overflow

Non-static private variables in javascript

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related