Angular: get input values in js function

Question

My controller is too big so was decided to split it to several functions. So now functions don't see input values. Could you advice me how to solve this problem?

angular.module("sampleApp", [])
    .controller("defaultCtrl", function ($scope) {

        $scope.addNewUser = function (userDetails, isvalid) {
          doLogin();
        }

    });

var doLogin = function(userDetails, isvalid) {
            if (isvalid) {
                $scope.message = userDetails.name + " " + userDetails.email;
            }
            else {
                $scope.message = "Error";
                $scope.showError = true;
            }
}

http://plnkr.co/edit/Rv6dqTECeD62HA1SgDM9?p=preview

asdf_enel_hak · Accepted Answer · 2016-05-11 10:46:23Z

3

While you call function, you should pass parameters

$scope.addNewUser = function (userDetails, isvalid) {
    doLogin(userDetails, isvalid,$scope);
}

var doLogin = function(userDetails, isvalid, $scope) {
    //...
}

http://plnkr.co/edit/G66gFmJVhiXljyxgLDLP?p=preview

Edit: to get user name length update doLogin function:

    var doLogin = function(userDetails, isvalid, $scope) {
                if (userDetails)
                   console.log(userDetails.name.length)
                //..
    }

edited May 11, 2016 at 10:46

answered May 11, 2016 at 9:58

asdf_enel_hak

7,6585 gold badges47 silver badges91 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

kipris Over a year ago

One more question: how can I get userDetails.name' length ?

tufac2 · Accepted Answer · 2016-05-11 10:00:51Z

2

You have broken down the controller into several functions. However

var doLogin = function(userDetails, isvalid) {
            if (isvalid) {
                $scope.message = userDetails.name + " " + userDetails.email;
            }
            else {
                $scope.message = "Error";
                $scope.showError = true;
            }
}

is out of the $scope of the controller

"defaultCtrl"

So if you want to have smaller controllers you can have several controllers and communicate them using an angular Factory.

To be honest. I think you should use the same controller to "CONTROL" all the stuff related with your login form.

answered May 11, 2016 at 10:00

tufac2

7986 silver badges9 bronze badges

2 Comments

kipris Over a year ago

One more question: how can I get userDetails.name' length ?

tufac2 Over a year ago

userDetails.name.lenght

Babu Swami · Accepted Answer · 2016-05-11 09:57:35Z

You have written your function outside the controller, therefore, the $scope is not available inside doLogin function. Apart from this, you did not pass values userDetails and isvalid values to doLogin call.

Replace your code with this:

angular.module("sampleApp", [])
    .controller("defaultCtrl", function ($scope) {
        $scope.addNewUser = function (userDetails, isvalid) {
          doLogin(userDetails, isvalid);
        }
        var doLogin = function(userDetails, isvalid) {
            if (isvalid) {
                $scope.message = userDetails.name + " " + userDetails.email;
            }
            else {
                $scope.message = "Error";
                $scope.showError = true;
            }
    } 
});

Collectives™ on Stack Overflow

Angular: get input values in js function

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related