Java robot doesn't work

Question

I was writing code which first adds mouse position to arraylist (with dealys) and after that, it will repeat by moveMouse (robot). I think that I'm doing all well. But it's not working. Can anyone help me? Thanks!

Code: CoursorMove

public class CoursorMove {

private ArrayList<Point> coordinates = new ArrayList<>();

public void addNewObjectWithCoordinates() {
    coordinates.add(MouseInfo.getPointerInfo().getLocation());
}

public Point getCoordinate(int index) {
    return coordinates.get(index);

}

public void play() {

    for (int i = 0; i < 5; i++) {
        CoursorMove bang = new CoursorMove();
        bang.addNewObjectWithCoordinates();
        System.out.println(bang.getCoordinate(0).getX());

        try {
            Thread.sleep(1500);
        } catch (InterruptedException e) {
            e.printStackTrace();
        }
    }
}

int howmany = coordinates.size();
int index = 0;

public int getHowmany() {
    return howmany;
}

public void setHowmany(int howmany) {
    this.howmany = howmany;
}

public void moveCoursor() {

    while (index < howmany) {
        try {
            Robot robot = new Robot();
            robot.mouseMove(coordinates.get(index).x, coordinates.get(index).y);
            robot.delay(1500);
        } catch (AWTException e) {
            System.err.println("Error CM 68L"); // error CoursorMove class
                                                // Line 68
            e.printStackTrace();
        }
        index++;
    }
}
 }

Main.

public class Main {
public static void main(String[] args) {
    CoursorMove triup = new CoursorMove();
    triup.play();
    triup.moveCoursor();
    }
}

Please describe what happens vs what should happen with a minimal reproducible example. Thank you — OneCricketeer
– OneCricketeer, Commented May 21, 2016 at 17:14
Hint: CoursorMove bang = new CoursorMove(); makes a brand new bang in every for loop and discards it at the end of the loop. Is that what you want? — OneCricketeer
– OneCricketeer, Commented May 21, 2016 at 17:16

OneCricketeer · Accepted Answer · 2016-05-21 20:27:08Z

3

Here are a few modifications that should help.

First, you don't need to store separate variables for how many coordinates you have

public int getHowmany() {
    return coordinates.size();
}

Second, you are never adding to the same coordinates list because you use a new instance of your class. You don't need to make one at all, you can call those methods directly on the current instance.

public void play() {

    for (int i = 0; i < 5; i++) {
        addNewObjectWithCoordinates();
        System.out.println(getCoordinate(0).getX());

        // sleep thread 
    }
}

Then same problem below, you probably only want one robot, not one for every loop

public void moveCoursor() {

    Robot robot = new Robot();
    while (index < getHowmany()) {
        try {
            robot.mouseMove...

edited May 21, 2016 at 20:27

answered May 21, 2016 at 17:26

OneCricketeer

193k20 gold badges146 silver badges276 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Brade Over a year ago

WoW! Man You're amazing! Wait... You and Hansa. I change only one with method play. I have object.getCoordinate. And after i have just getCoordinate. I delete object from the code. And all is fantastic working! Big thanks! Have a nice day!

Haphil · Accepted Answer · 2016-05-21 17:27:24Z

2

Did you verify that you jump into the

while (index < howmany) {}

loop?

from what I see here is you put:

int howmany = coordinates.size();
int index = 0;

into your class directly. But you never update "howmany" after you added items to it. As a result is howmany = 0 at initialization, because coordinates.size() is 0 in the beginning.

I guess you have to set "howmany"'s value after you added your coordinates.

e.g.

public void play() {

  for (int i = 0; i < 5; i++) {
    addNewObjectWithCoordinates();
    System.out.println(getCoordinate(0).getX());

    try {
        Thread.sleep(1500);
    } catch (InterruptedException e) {
        e.printStackTrace();
    }
  }
  howmany = coordinates.size();
}

EDIT: Additionally you have to stop creating a new CoursorMove object every time. I updated the play method for that

edited May 21, 2016 at 17:27

answered May 21, 2016 at 17:15

Haphil

1,2601 gold badge18 silver badges39 bronze badges

4 Comments

Haphil Over a year ago

yes, thats what I am saying. :) Therefore I added 'howmany = coordinates.size();' to the play() method.

Brade Over a year ago

Thanks for your answer. I updated the code, but problem isnt fixed. Any suggest?

Haphil Over a year ago

could you verify that you enter the while loop? you could debug it or add a System.out.println into the loop

Brade Over a year ago

Sure, I added println, and it isnt writing. Like program don't see this method. But before before when i wasnt add question on stackover loop give me some error but compiler dont find antyhing bad.

Collectives™ on Stack Overflow

Java robot doesn't work

2 Answers 2

1 Comment

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related