PHP Json only a first result

Question

My issue is that when I use foreach trough my JSON commands it will only give the first command. In this case HELP but not the second one that is Test.

How can I fix this?

PHP:

echo "Commands:<br>";
$json = file_get_contents("App/cmd/commands.json");
$register = json_decode($json, true);
$command = $_GET["c"];
foreach ($register['commands'] as $key => $value){
    echo $key;
    if($command == $key)
    {
        echo "Found!";
        return;
    }
    if(isset($register["commands"][$key]["alias"])){
        echo "&nbsp;&nbsp; Has Aliases<Br>";
        $aliases = explode(",", $register["commands"][$key]["alias"]);
        foreach ($aliases as $alias)
        {
            if($command == $alias)
            {
                echo "Found!";
                return;
            }
        }
    }
    echo "Not Found!";
    return;
}

My Json:

{"help":"value","commands":{"help":{"function":"test"},"test":{"function":"test"}}}

"alias" is not in your sample data

Majid Abbasi
– Majid Abbasi

2016-05-22 14:55:02 +00:00
Commented May 22, 2016 at 14:55 — Majid Abbasi
– Majid Abbasi, Commented May 22, 2016 at 14:55
What are you passing in $_GET["c"]

RiggsFolly
– RiggsFolly

2016-05-22 15:00:07 +00:00
Commented May 22, 2016 at 15:00 — RiggsFolly
– RiggsFolly, Commented May 22, 2016 at 15:00

nospor · Accepted Answer · 2016-05-22 15:27:46Z

3

It is because you set

   echo "Not Found!"; return;

in the loop so there is no chance for second iteration. That code should be after loop not inside.

answered May 22, 2016 at 15:27

nospor

4,2301 gold badge18 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Felippe Duarte · Accepted Answer · 2016-05-22 15:46:17Z

2

Because you have return; everywhere. Then you can't have a second iteration, because you always finish the process. Remove the return according to your logic to have a second iteration and make proper refactor to your code, to make it functional.

answered May 22, 2016 at 15:46

Felippe Duarte

15.2k2 gold badges27 silver badges29 bronze badges

1 Comment

Joey de Vries Over a year ago

Thanks for the suggestion, I will make the change!

Collectives™ on Stack Overflow

PHP Json only a first result

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related