Why this JavaScript code doesn't work?

Question

I have for loop which goes through the array with arguments. When next argument is "?", "&" or "||", it shouldn't add comma, however, it always adds. I couldn't understand why, here is the code:

var args = ["arg1","arg2","?","arg3"];
var query = "";
for (var i = 0; i < args.length; i++) {

		switch (args[i]) {

			case "?":
				query += " where ";
				break;

			case "&":
				query += " and ";
				break;

			case "||":
				query += " or ";
				break;

			default:
				if (args[i+1] != "?"); 
				{
					query += args[i] + ", ";
					break;
				}
				query += args[i] + " ";
				break;

		}

	}
document.write(query);

When I type this (this is splitted by " " and sent to array args):

arg1 arg2 ? arg3

It prints it like this:

arg1, arg2, where arg3, // while it should be arg1, arg2 where arg3,

Thanks for helping people, problem was caused by an extern script. And yes, I removed semicolon ;)

where is it different arg1, arg2, where arg3, // while it should be arg1, arg2 where arg3,? — Nina Scholz
– Nina Scholz, Commented May 26, 2016 at 18:43
@NinaScholz that comma after arg2 before where is not wanted apparently. — Pointy
– Pointy, Commented May 26, 2016 at 18:43
Prints where? You're probably "printing" an array, and its toString method adds the comma. — Teemu
– Teemu, Commented May 26, 2016 at 18:44
@Teemu When I print query variable. Query variable is string and is defined before this loop. — Nikola Stojaković
– Nikola Stojaković, Commented May 26, 2016 at 18:44

Pointy · Accepted Answer · 2016-05-26 18:50:47Z

5

Your if statement is broken:

        if (args[i+1] != "?"); // <---- remove that semicolon
        {
            query += args[i] + ", ";
            break;
        }

You've got a stray semicolon. It is not a syntax error, but it means the if doesn't do anything. The code that adds the comma always runs, and exits the switch before the code that doesn't add the comma.

edited May 26, 2016 at 18:50

answered May 26, 2016 at 18:47

Pointy

415k62 gold badges600 silver badges631 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Pointy Over a year ago

@CayceK I have, and I've also run the code. It works without the semicolon.

Nikola Stojaković Over a year ago

Thanks for trying to help out but I solved this. This problem was caused by another array from extern script, now everything works. Thanks for answers anyway.

Pointy Over a year ago

@Nikola trust me, you want to get rid of that semicolon.

Syed Ekram Uddin Over a year ago

@Nikola The problem is ppl vote for the wrong answer without knowing the whole story (for comments here and there). This could misguide other persons to find out the right answer, which is lies in a comment.

Pointy Over a year ago

@SyedEkramUddinEmon Except in this case it's not the wrong answer. That semicolon dramatically changes the meaning of the code.

|

MikeJfromVA · Accepted Answer · 2016-05-26 18:51:44Z

1

You have a semicolon between your if and your block:

if (args[i+1] != "?");

Should be

if (args[i+1] != "?")

answered May 26, 2016 at 18:51

MikeJfromVA

5132 gold badges5 silver badges13 bronze badges

Comments

Paul S. · Accepted Answer · 2016-05-26 19:05:13Z

1

There may be completely different ways to solve this problem which would make your code easier to extend without deepening trees of if or switch

A quick example,

// define some dictionaries
let logicDict = Object.assign(Object.create(null), {
    '?': 'where',
    '&': 'and',
    '||': 'or'
});

// define some flags
let noComma = false;

// reduce your array
['arg1', 'arg2', '?', 'arg3'].reduceRight((str, e) => {
    if (e in logicDict) {
        noComma = true;
        return logicDict[e] + ' ' + str;
    }
    if (!noComma) e += ',';
    noComma = false;
    return e + ' ' + str;
}, '').slice(0, -1);
// "arg1, arg2 where arg3,"

answered May 26, 2016 at 19:05

Paul S.

66.6k9 gold badges129 silver badges143 bronze badges

1 Comment

Nikola Stojaković Over a year ago

This is very interesting. Thanks!

Nikola Stojaković · Accepted Answer · 2016-05-26 19:14:36Z

0

Thanks for noticing semicolon guys, problem was caused by an extern script.

answered May 26, 2016 at 19:14

Nikola Stojaković

2,3056 gold badges29 silver badges54 bronze badges

3 Comments

Pointy Over a year ago

Your script, modified only to declare query and to hook args up to process.argv as a Node.js program, did not work with the semicolon but it did work correctly once the semicolon was removed.

1983 Over a year ago

Indeed. Leave that semicolon in and it'll still be wrong.

Nikola Stojaković Over a year ago

LOL, I said thanks for noticing semicolon guys, and you're still complaining about ..king semicolon?! Yes, that was an error, I know! No matter how it sounds stupid, but it actually worked even with that semicolon (and I'm really not sure how, but I removed it). I won't repeat this guys. Please, there's nothing new to say about this. Thanks for noticing, again!

Collectives™ on Stack Overflow

Why this JavaScript code doesn't work?

4 Answers 4

10 Comments

Comments

1 Comment

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

10 Comments

Comments

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related