os.mkdir under if not working python

Question

I have the below code, the os.mkdir is not working on mine. Compiling does not return any error, but running the code does not create folder.

def folder():
    timenow = datetime.now().strftime('%Y-%m-%d_%H%M%S')
    folderpath = os.path.join(currentpath,"folder",str(timenow))
    if os.path.exists(folderpath) == False:
        os.mkdir(folderpath)
    return

You don't compile under Python. You meant "running does not return any [runtime] error"... — mannyglover
– mannyglover, Commented Aug 13, 2018 at 23:46

101 · Accepted Answer · 2016-05-31 00:38:28Z

10

Try this:

def folder():
    timenow = datetime.now().strftime('%Y-%m-%d_%H%M%S')
    folderpath = os.path.join(currentpath, "folder", str(timenow))
    if not os.path.exists(folderpath):
        os.makedirs(folderpath)
        print 'Created:', folderpath

folder()

makedirs will create the required subdirectories, whereas mkdir can only create one directory. That said, you should've seen an exception.

edited May 31, 2016 at 0:38

answered May 31, 2016 at 0:30

101

9,0676 gold badges47 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

python novice Over a year ago

Thanks for this!, Just wondering why makedir shows an exception now when it works fine yesterday for the same code.

101 Over a year ago

No worries. It may have been that the subdirectories already existed and you were only creating the timenow dir on the end (which should work).

AWainb · Accepted Answer · 2016-05-31 00:53:55Z

0

Here's my stab at it, with some minor error handling...

def folder():
    timenow = datetime.now().strftime('%Y-%m-%d_%H%M%S')
    folderpath = os.path.join(os.getcwd(),"folder",str(timenow))
    if not os.path.exists(folderpath):
        os.makedirs(folderpath)
        if os.path.exists(folderpath):
            return (True, folderpath)
    return (False, folderpath)

f = folder()

if f[0]:
    print '"%s" was successfully created!' % (f[1])
else:
    print '"%s" could not be created, does the folder already exist? Do you have appropriate permissions to create it?' % (f[1])

answered May 31, 2016 at 0:53

AWainb

8882 gold badges13 silver badges28 bronze badges

2 Comments

python novice Over a year ago

thanks for this but the first IF handles the one inside it dont you think?

AWainb Over a year ago

If the folder does not exist, create it, then the second if is used to ensure the folder you just created was actually successfully created. Just because you said to create a folder doesn't mean there are not other variables on your system that might cause the folder creation you initiated to fail, like permission issues, full hdd, bad sectors, etc.

Collectives™ on Stack Overflow

os.mkdir under if not working python

2 Answers 2

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related