Creating stack using linked list

Question

I'm trying to create my stack, using my linked listed functions that I already created. I have the following:

listNode *createList()
{
    listNode *anyNode;
    anyNode = malloc(sizeof(listNode));
    anyNode->next = NULL;
    return anyNode;
}

stack *createStack()
{
    stack *temp;
    stack.list = createList();
    return temp;
}

and in my main I call it using:

int main(void)
{   
    stack *theStack;
    theStack = createStack();
    return(0);
}

I defined my stack as:

typedef struct stack {
    listNode *list;
}stack;

I get a compiler error: expected identifier or '(' at my stack.list = createList() call in my createStack function. I'm not sure why.

My main works if I change

stack *theStack

into

 listNode *list

then just call it as: list = createList();

@iharob and what's your point??? it's perfectly valid, take a look at the BSD source if you aren't happy about it. — Ryan
– Ryan, Commented May 31, 2016 at 1:16
Do you have any questions about the actual implementation (the interesting part)? — Tim Biegeleisen
– Tim Biegeleisen, Commented May 31, 2016 at 1:17
@self I am not acting like that, I am just trying to point out that it's deprecated style that and that it's not needed. Read my comment again please. — Iharob Al Asimi
– Iharob Al Asimi, Commented May 31, 2016 at 1:21

Iharob Al Asimi · Accepted Answer · 2016-05-31 01:17:01Z

1

You are declared temp as a pointer of type stack but then you write

stack.list = ...

stack in your code is a type not a variable, you can't use it like that.

You need a variable instead, something like

stack my_stack;
my_stack.list = ...

if you want it to be a pointer, then you need to use malloc() to allocate space for it.

answered May 31, 2016 at 1:17

Iharob Al Asimi

53.1k6 gold badges66 silver badges100 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

FreeStyle4 Over a year ago

I think that worked. I have a question for printing now. I wrote my push function and I think it works as well, how do I test printing the nodes in my stack go? Im not sure how it works since my stack only takes a listNode* list.

FreeStyle4 Over a year ago

In my linked list, I would just print printf("%d",list->value);

Rishikesh Raje Over a year ago

@iharob when you return a pointer to this my_stack variable, it will be returning a local variable. Better to declare a pointer and call the createstack function on it.

Iharob Al Asimi Over a year ago

@RishikeshRaje I never suggested to do that. If the stack variable will only be used locally there is no harm in doing it without a pointer, although mostly that would not be the case. My answer tries to illustrate the syntax error rather than how it should be done.

Rishikesh Raje · Accepted Answer · 2016-05-31 04:43:00Z

0

The problem is in the createstack function.

stack.list = createList()

stack is a global variable, and you should be using the local variable temp here. You need to allocate size for the stack structure also here.

stack *createStack()
{
  stack *temp;
  temp = malloc(sizeof(stack));
  temp->list = createList();
  return temp;
}

answered May 31, 2016 at 4:43

Rishikesh Raje

8,6222 gold badges18 silver badges33 bronze badges

Collectives™ on Stack Overflow

Creating stack using linked list

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related