Bash script if .. else .. not working

Question

I'm new to the Bash scripting. I added the if .. else in the Bash script. My script is for making Docker-containers if the container doesn't exist, and creating a new container if it does exist. But the script never runs the else block; it always run the if block.

My script:

#!/bin/bash
tomcat=$(ssh [email protected] sudo docker ps -a | grep -w 'my-tomcat')
echo "$?"

if [ "$BRANCH" = "tomcat" ] && [ "$?" -eq 0 ]; then
        ssh [email protected] /bin/sh <<-EOF
                { cd tomcat/ && sudo docker stop my-tomcat && sudo docker rm my-tomcat; } \
                && { sudo docker build -t tomcat .; } \
                && { sudo docker run -h tomcat --name my-tomcat -itd -p 2013:8080 tomcat; } \
                && { sudo docker start my-tomcat; }
        EOF
else
        ssh [email protected] /bin/sh <<-EOF
                { cd tomcat/ && sudo docker build -t tomcat .; } \
                && { sudo docker run -h tomcat --name my-tomcat -itd -p 2013:8080 tomcat; } \
                && { sudo docker start my-tomcat; } 
        EOF
fi

Copy pasted your script in shellcheck.net and it threw an ugly error When using <<-, you can only indent with tabs. Fixing that error might help you solve the problem — Inian
– Inian, Commented Jun 3, 2016 at 7:34
Is "$BRANCH" equals "tomcat" all the time and what is the reason behind taking variable tomcat? — Krishna
– Krishna, Commented Jun 3, 2016 at 7:40
I would try assigning the $? to a variable (rc) before using it in the if and write if [[ "$BRANCH" = "tomcat" && "$rc" -eq 0 ]] ... It may be that $? after the && is actually no longer referring to your original return code. — Stefan Hegny
– Stefan Hegny, Commented Jun 3, 2016 at 7:42

Will · Accepted Answer · 2016-06-03 07:45:25Z

2

Once you run:

echo "$?"

if [ "$BRANCH" = "tomcat" ] && [ "$?" -eq 0 ]; then

In your if statement, "$?" will always be 0, because it will represent the return value of [ "$BRANCH" = "tomcat" ]. And even if it didn't, it would represent the return value of the echo.

Do this instead to preserve the exit code:

tomcat="$(ssh [email protected] sudo docker ps -a | grep -w 'my-tomcat')"
tomcat_status="$?"

echo "$tomcat_status"

if [ "$BRANCH" = "tomcat" ] && [ "$tomcat_status" -eq 0 ]; then

answered Jun 3, 2016 at 7:45

Will

24.8k14 gold badges100 silver badges111 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Will Over a year ago

No problem, glad to help!

Andreas Louv · Accepted Answer · 2016-06-03 07:45:03Z

2

[ .. ] && [ "$?" -eq 0 ]
#            ^ This will always be 0, since it's referring to the previous 
#              commands ([ .. ]) exit code

Store the exit code from earlier:

tomcat=$(ssh [email protected] sudo docker ps -a | grep -w 'my-tomcat')
tomcat_exit=$?

And what is $BRANCH? And tomcat?

if [ "$BRANCH" = "$tomcat" ] && [ "$tomcat_exit" -eq 0 ]; then
#                 ^ Is this a constant "tomcat" or variable "$tomcat"?

answered Jun 3, 2016 at 7:45

Andreas Louv

47.3k14 gold badges109 silver badges126 bronze badges

1 Comment

Will Over a year ago

Oops, sorry, we worked on the same answer at the same time :)

Will · Accepted Answer · 2016-06-03 07:50:34Z

1

To aid debugging, type set -x before the if-statement, and set +x after the fi statement.

This enables execution tracing, and you can see the substitution for $branch and $?!.

edited Jun 3, 2016 at 7:50

Will

24.8k14 gold badges100 silver badges111 bronze badges

answered Jun 3, 2016 at 7:44

SimpleCheck

111 bronze badge

Collectives™ on Stack Overflow

Bash script if .. else .. not working

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related