cannot implicit convert type string string[]

Question

I want to store string into string array, but it shows error. Here is my code:

List <ResponseObject> myresponse =JsonConvert.DeserializeObject<List<ResponseObject>>(responseFromServer);
string [] DomainArray;
for (int i = 0; i < myresponse.Count; i++)
{
    for (int j = 0; j < myresponse[i].EmailAddressSuffixes.Count; j++)
    {
        DomainArray = myresponse[i].EmailAddressSuffixes[j];
    }
}

You need to initiatialize the array, like this: string [] DomainArray = new string[myresponse.Count]; — Hugo Quintela Ribeiro
– Hugo Quintela Ribeiro, Commented Jun 3, 2016 at 10:41
@HugoQuintelaRibeiro: this won't work because it's the count of myresponses AND EmailAddressSuffixes — M. Schena
– M. Schena, Commented Jun 3, 2016 at 10:45
since arrays are not dynamic, think about working with lists — M. Schena
– M. Schena, Commented Jun 3, 2016 at 10:47

bolt19 · Accepted Answer · 2016-06-03 10:45:31Z

1

You are trying to assign the DomainArray (which is an array of strings) to a single string.

Try this, it adds all the values to a list then converts to list to an array:

    List<ResponseObject> myresponse = JsonConvert.DeserializeObject<List<ResponseObject>>(responseFromServer);
    List<string> DomainList = new List<string>();
    for (int i = 0; i < myresponse.Count; i++)
    {
        for (int j = 0; j < myresponse[i].EmailAddressSuffixes.Count; j++)
        {
            DomainList.Add(myresponse[i].EmailAddressSuffixes[j]);
        }
    }
    var DomainArray = DomainList.ToArray();

answered Jun 3, 2016 at 10:45

bolt19

2,0734 gold badges34 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

shadow · Accepted Answer · 2016-06-03 10:45:28Z

0

List <ResponseObject> myresponse =JsonConvert.DeserializeObject<List<ResponseObject>>(responseFromServer);
var DomainArray = new List<string>();
for (int i = 0; i < myresponse.Count; i++)
{
for (int j = 0; j < myresponse[i].EmailAddressSuffixes.Count; j++)
{
DomainArray.Add( myresponse[i].EmailAddressSuffixes[j] );
}
}

Then you can get the array (if required) using DomainArray.ToArray()

answered Jun 3, 2016 at 10:45

shadow

1,9031 gold badge17 silver badges25 bronze badges

Comments

M. Schena · Accepted Answer · 2016-06-03 10:49:19Z

0

Since arrays are not dynamic, think about working with lists:

List <ResponseObject> myresponse =JsonConvert.DeserializeObject<List<ResponseObject>>(responseFromServer);
List<string> DomainArray = new List<string>();
for (int i = 0; i < myresponse.Count; i++)
{
    for (int j = 0; j < myresponse[i].EmailAddressSuffixes.Count; j++)
    {
        DomainArray.add(myresponse[i].EmailAddressSuffixes[j]);
    }
}

answered Jun 3, 2016 at 10:49

M. Schena

2,1071 gold badge24 silver badges30 bronze badges

Comments

Malik Kashmiri · Accepted Answer · 2016-06-03 10:58:39Z

0

I made two changes in my above code. first from @Hugo and second from @Roma

List <ResponseObject> myresponse = JsonConvert.DeserializeObject<List<ResponseObject>>(responseFromServer);
List<string> DomainArray = new List<string>();
for (int i = 0; i < myresponse.Count; i++)
{
    for (int j = 0; j < myresponse[i].EmailAddressSuffixes.Count; j++)
    {
        DomainArray.Add(myresponse[i].EmailAddressSuffixes[j]);
    }
}

edited Jun 3, 2016 at 10:58

answered Jun 3, 2016 at 10:48

Malik Kashmiri

5,88113 gold badges46 silver badges82 bronze badges

5 Comments

bolt19 Over a year ago

You will receive a ArgumentOutOfRangeException as you are setting the array to a length of myresponse rather than the length of all the EmailAddressSuffixes

M. Schena Over a year ago

@AhmedJalal: have a look at my answer used List<string> instead of static arrays

bolt19 Over a year ago

It will only work if each each response item has only one EmailAddressSuffix

Malik Kashmiri Over a year ago

after checking again @bolt19 answer is according to my expectations

M. Schena Over a year ago

@AhmedJalal thank you for unaccepting my answer, copy paste it to your edited answer and mark this as answer and accept it to earn reputation for your own.

Collectives™ on Stack Overflow

cannot implicit convert type string string[]

4 Answers 4

Comments

Comments

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related