ASP.NET MVC2 inline code in view - mixing tags

Question

I've run into a couple different exceptions with this block of code in one of my views:

<% if (Model.Book.ReviewReference == null)
   {%>
       <%=Html.ActionLink("Rate / review this book", "Create", "Review", null, new { id = "reviewLink" }) %>
      <% Html.RenderPartial("CreateReview");
   }
   else
   {%> 
       <%= Html.ActionLink("Edit this book's rating / review","Edit", "Review", new { reviewID = Model.Book.ReviewID}, new {id = "reviewLink"}) %>
        <% Html.RenderPartial("EditReview", Model.Book.Review, new ViewDataDictionary());
   }  %>

The first error I encountered was described here: link text

thus the Html.RenderPartial("EditReview", Model.Book.Review, new ViewDataDictionary()) you see towards the end there.

Another problem I encountered is when the if condition is evaluated for a ReviewReference that is in fact null, the else statement is still being reached somehow, and the second partial view is making an unsuccessful attempt to render itself.

Have I used these alternating inline-code tags in an incorrect manner? How does one go back and forth between <% %> and <%= %> properly?

Thank you.

Edit:

OK, I marked an answer too soon. I just tried it with the given code from the answer, and that else block is still being evaluated, and trying to pass null objects to the partial view...darn it.

p.campbell · Accepted Answer · 2010-09-21 22:17:46Z

1

You are correct in your usage of the tags there.

They aren't 2 alternating styles, but differences in how the view engine deals with different statements. It's not surprising that it can get confusing.

<%= : Think of this as Response.Write(). You supply it with a string.

<% Html.RenderPartial - this is a command given to the view engine to actually render a partial view. You're not giving it a string, but rather telling the view to go get another snippet (partial view), and write it out.

answered Sep 21, 2010 at 22:17

p.campbell

101k70 gold badges263 silver badges326 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Robert Koritnik · Accepted Answer · 2010-09-21 22:33:34Z

1

Missing a couple of closing %>

<% if (Model.Book.ReviewReference == null)
   {%>
       <%=Html.ActionLink("Rate / review this book", "Create", "Review", null, new { id = "reviewLink" }) %>
      <% Html.RenderPartial("CreateReview"); %>
   <%}
   else
   {%> 
       <%= Html.ActionLink("Edit this book's rating / review","Edit", "Review", new { reviewID = Model.Book.ReviewID}, new {id = "reviewLink"}) %>
        <% Html.RenderPartial("EditReview", Model.Book.Review, new ViewDataDictionary()); %>
   <% }  %>

edited Sep 21, 2010 at 22:33

Robert Koritnik

105k57 gold badges286 silver badges415 bronze badges

answered Sep 21, 2010 at 22:26

Christopher Edwards

6,6598 gold badges49 silver badges58 bronze badges

2 Comments

asfsadf Over a year ago

OK, thanks a lot for straightening me out on this one. Why those closing tags are needed makes no sense to me, though. That's probably why I loused it up to begin with.

asfsadf Over a year ago

That's a hell of a lot of tags, now that I look at it again. Sheesh!

asfsadf · Accepted Answer · 2010-09-21 23:47:23Z

1

OK, so it turns out my tag usage was fine, but my if condition was off. It needed to be:

if (Model.Book.ReviewReference.EntityKey == null)

I was missing the EntityKey property.

answered Sep 21, 2010 at 23:47

asfsadf

3,8827 gold badges35 silver badges41 bronze badges

Collectives™ on Stack Overflow

ASP.NET MVC2 inline code in view - mixing tags

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related