Sorting array by alphabet will not function correctly

Question

Code I am talking about: https://jsfiddle.net/sbe8yzv0/8/

I want to sort my array by the name with two buttons: First button sorts it by length and second buttons sorts it by alphabet.

When I sort by alphabet it doesn't want to function. It randomly puts the data in different positions. I have tried multiple ways of sorting it and they all act funky and doesn't sort it completely alphabetically. What can I do to make it actually sort the name in array by alphabet?

    function sortNameAlphabetically(a, b) {
        return a.name > b.name;
    }

The sort by length is working as intended except when it sorts alpabeticly after length it does it bakwards. How do I make sure it sorts the right way?

    function sortNameByLength(a, b) {
        return b.name.length - a.name.length;
        a.localeCompare(b);

Your first comparison function is invalid.

Bergi
– Bergi

2016-06-14 14:14:45 +00:00
Commented Jun 14, 2016 at 14:14 — Bergi
– Bergi, Commented Jun 14, 2016 at 14:14

gurvinder372 · Accepted Answer · 2016-06-14 13:57:48Z

2

change the sortNameAlphabetically method to

  function sortNameAlphabetically(a, b) {
        return a.name.localeCompare( b.name );
    }

updated fiddle

Also, statement after return statement in sortNameByLength method is not reachable and not required anyways.

    function sortNameByLength(a, b) {
        return b.name.length - a.name.length;
    }

answered Jun 14, 2016 at 13:57

gurvinder372

68.6k11 gold badges78 silver badges98 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Thomasdc Over a year ago

Awesome. Do you know how I can fix the second problem?

gurvinder372 Over a year ago

@Thomasdc simply return a.name.length - b.name.length;

Thomasdc Over a year ago

But how do I make it sort it alphabetically after being sorted by length then? So if I have ABA, BBBB, AAAA, AAA. It should be AAAA, BBBB, AAA, ABA

Nina Scholz · Accepted Answer · 2016-06-14 14:16:07Z

1

Part two of the question, to maintain the alphabetical sorting after length sorting, you can use a logical OR with the localeCompare method.

function sortNameByLength(a, b) {
    return b.name.length - a.name.length || a.name.localeCompare(b.name);
}

edited Jun 14, 2016 at 14:16

answered Jun 14, 2016 at 14:11

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

3 Comments

Thomasdc Over a year ago

I have already tried this and it doesn't work. Nothing happens. jsfiddle.net/sbe8yzv0/10

Nina Scholz Over a year ago

please try edit. you need to address the name property.

Thomasdc Over a year ago

Very nice. Thanks a lot! :)

Collectives™ on Stack Overflow

Sorting array by alphabet will not function correctly

2 Answers 2

3 Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related