Asp.net MVC foreach loop over db only returns 1 row

Question

My Controller View

foreach (var dbItem in db1.Ranges.Where(x => x.DeviceId == Id).OrderByDescending(x => x.DeviceTime))
{
    list.Add((double)dbItem.Val1);
}

My Database rows --> Database Table

As you can see there are alot of rows in the DB, but when i run it i only get 1 row.

Maybe a stupid question, but are you sure that you're quering the same DB as the screenshot? And if so, which Val1 are you getting? And are you using DevideID 162201083007044? — smoksnes
– smoksnes, Commented Jun 16, 2016 at 12:35

smoksnes · Accepted Answer · 2016-06-16 12:39:17Z

1

You can try:

var items = db1.Ranges
                 .Where(x => x.DeviceId == Id)
                 .OrderByDescending(x => x.DeviceTime)
                 .Select(x => x.Val1)
                 .ToList();

// if list is a List<double>
list.AddRange(items.Select(x => (double)x));

// If you really need the foreach
foreach(var value in items)
{
    list.Add((double)value);
}

answered Jun 16, 2016 at 12:39

smoksnes

10.9k5 gold badges60 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

uTeisT Over a year ago

Care to elaborate a bit why we need items.Select(x => (double)x) ? I mean, I couldn't really see the difference. Just wondering if I'm missing something.

smoksnes Over a year ago

Are you pointing out the fact that I moved the cast? It's an old habit from my side. I always try to avoid too much logic in the query. But I'm sure it can be done in the query as well. Also, I added .ToList() in to query the DB before we iterate it.

uTeisT Over a year ago

Ah, now I see. I missed .ToList() was missing in OP. Nice catch!

Collectives™ on Stack Overflow

Asp.net MVC foreach loop over db only returns 1 row

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related