html5 localstorage not saving input

Question

I'm trying to safe a value in localstorage to use it later on other pages, but I can't quite get it to work.

My input field:

<input type="text" name="test" value="" id="test" required />
         <span class="highlight"></span>
         <span class="bar"></span>
         <label>enter something</label>

My script:

<script>

function getStorage(type) {
  var storage = window[type + 'Storage'],
    delta = 0,
    p = document.createElement('p');

  if (!window[type + 'Storage']) return;

  if (storage.getItem('value')) {    
    p.innerHTML = type + 'Storage: ' + storage.getItem('value');
  } else {
    p.innerHTML = type + 'nothing safed';
  }

  document.querySelector('#output').appendChild(p);
}

getStorage('test');


addEvent(document.querySelector('#test'), 'keyup', function () {
  localStorage.setItem('value', this.value);
});


</script>

My output:

    <p id="output"></p>

Note: I'm using h5utils.js (https://java.net/projects/prototype/sources/svn/content/trunk/demosprojects/AjaxAdmin/web/h5utils.js?rev=11) to make it all work, but I can't get output. No errors in the console.

Well, there's no such thing as window.testStorage, so your getStorage('test') call will return immediately. — Heretic Monkey
– Heretic Monkey, Commented Jun 21, 2016 at 17:15
All I see here is a value being written to localStorage with the key "value", then you try to get values out from testStorage, which is meaningless. Call getStorage('local') instead. — ManoDestra
– ManoDestra, Commented Jun 21, 2016 at 17:15
Thanks for the responses! Will changing getStorage('test') to getStorage('local') do the trick? — peter vries
– peter vries, Commented Jun 21, 2016 at 17:17

ManoDestra · Accepted Answer · 2016-06-21 17:17:44Z

1

You're calling the getStorage function passing a type of 'test', which then attempts to look up window.testStorage which doesn't exist of course.

Use...

getStorage('local');

... instead to look up localStorage.

answered Jun 21, 2016 at 17:17

ManoDestra

6,5236 gold badges29 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

peter vries Over a year ago

stupid mistake, I should take a break and get some coffee. Anyway, thanks a lot!

Collectives™ on Stack Overflow

html5 localstorage not saving input

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related