Regex in python for not matching word

Question

I am reviewing java code and there are so many classes to check, I made a regex to find a method written in java that doesn't close IO stream within finally block.

(?s)(?<=public|private|protected).(?<!finally).*?.close\(\)\;

For some reason this doesn't work and it matches even those methods that has finally block, so below is found too

public testMethod(){
   InputStream stream = .....
   try{ 
     //do something
   } finally {
      if(stream != null){
         stream.close();
      }
   }
}

While only below should be matched

public testMethod(){
   InputStream stream = .....
   //do something
   if(stream != null){
     stream.close();
  }
}

Any pointers ?

A method in Java can just start without (public|private|protected) also — anubhava
– anubhava, Commented Jun 22, 2016 at 5:10
Thanks for replying, but lets assume our coders used access modifiers for all methods. — Dwarf_Ostrich
– Dwarf_Ostrich, Commented Jun 22, 2016 at 5:13

Richard · Accepted Answer · 2016-06-22 06:27:11Z

1

Your regex should probably be : (?s)(?<=public|private|protected)((?!finally).)*close\(\)\;. Demo on regex101.

Explanation : ((?!finally).)* verify that the rest of the string does not contain finally.

Note : in order to cover all cases, you might also want to check if the close() is actually inside the block of the finally. You can do it with an expression like (?s)(?<=public|private|protected)((?!finally[^}]*close\(\)\;).)*close\(\)\;.

edited Jun 22, 2016 at 6:27

answered Jun 22, 2016 at 5:44

Richard

1,0511 gold badge12 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Dwarf_Ostrich Over a year ago

Works perfect thanks, about close inside finally block, how can I achieve this ?

Richard Over a year ago

@Dwarf_Ostrich No problem. However you should avoid to use comment for this purpose

Collectives™ on Stack Overflow

Regex in python for not matching word

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related